Re: [PATCH] Add Dell XPS 15 9530 ALC289 speaker fix

[Takashi Iwai <tiwai@suse.de>]

On Tue, 04 Jul 2023 15:02:23 +0200,
Pentracillin@ wrote:
> 

Thanks for your patch.  But it needs a lot of things to be improved.

A patch must have a description to explain why this change is needed
and what / how the patch works.  Please fill the text.

And, your Signed-off-by tag is mandatory.  It's a legal requirement to
merge to the upstream, and it needs to be with a real name.

Also, please put the new quirk entry at the right position.  The table
is sorted in PCI SSID order.

Last but not least, please put a proper prefix to the subject line.
In your case, it'd be like 'ALSA: hda/realtek: ...."


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index afe8253f9..b5b80b6cd 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9355,6 +9355,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1028, 0x0a9d, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x1028, 0x0a9e, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x1028, 0x0b19, "Dell XPS 15 9520", ALC289_FIXUP_DUAL_SPK),
> +	SND_PCI_QUIRK(0x1028, 0x0beb, "Dell XPS 15 9530", ALC289_FIXUP_DUAL_SPK),
>  	SND_PCI_QUIRK(0x1028, 0x0b1a, "Dell Precision 5570", ALC289_FIXUP_DUAL_SPK),
>  	SND_PCI_QUIRK(0x1028, 0x0b37, "Dell Inspiron 16 Plus 7620 2-in-1", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS),
>  	SND_PCI_QUIRK(0x1028, 0x0b71, "Dell Inspiron 16 Plus 7620", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS),
> -- 
> 2.34.1
>