Re: [PATCH] ALSA: usb-audio: Rename Pioneer mixer channel controls

Re: [PATCH] ALSA: usb-audio: Rename Pioneer mixer channel controls

[Takashi Iwai]

On Thu, 08 May 2025 21:22:23 +0200,
František Kučera wrote:
> 
> From: František Kučera <franta-linux@frantovo.cz>
> 
> so alsamixer can show the controls in correct categories: capture/playback
> 
> Signed-off-by: František Kučera <franta-linux@frantovo.cz>

Applied now.  Thanks.


Takashi

Re: [PATCH] ALSA: usb-audio: Rename Pioneer mixer channel controls

[Takashi Iwai]

On Sun, 11 May 2025 16:16:39 +0200,
Takashi Iwai wrote:
> 
> On Thu, 08 May 2025 21:22:23 +0200,
> František Kučera wrote:
> > 
> > From: František Kučera <franta-linux@frantovo.cz>
> > 
> > so alsamixer can show the controls in correct categories: capture/playback
> > 
> > Signed-off-by: František Kučera <franta-linux@frantovo.cz>
> 
> Applied now.  Thanks.

... on the second thought, I'm not sure whether the proposed new names
are the best choice.  Now we see "Capture" and "Playback" twice for
ChX switches (also for Master switch, too):

+	SND_DJM_CTL("Master Capture Level Capture Switch", cap_level, 0, SND_DJM_WINDEX_CAPLVL),
+	SND_DJM_CTL("Capture Ch1 Capture Switch",  250mk2_cap1, 2, SND_DJM_WINDEX_CAP),
+	SND_DJM_CTL("Capture Ch2 Capture Switch",  250mk2_cap2, 2, SND_DJM_WINDEX_CAP),
+	SND_DJM_CTL("Capture Ch3 Capture Switch",  250mk2_cap3, 0, SND_DJM_WINDEX_CAP),
+	SND_DJM_CTL("Playback Ch1 Playback Switch", 250mk2_pb1, 0, SND_DJM_WINDEX_PB),
+	SND_DJM_CTL("Playback Ch2 Playback Switch", 250mk2_pb2, 1, SND_DJM_WINDEX_PB),
....

I guess your intention to make the differences clearer, but still it
leaves me some itch feeling.

And now I noticed that you've submitted to a wrong list.  The kernel
patches should be sent to linux-sound@vger.kernel.org, not alsa-devel.
So I drop the patch for now.

Let me know if you believe this is the best naming, or if you have any
other proposals.  And for the next patch, please submit to linux-sound
ML instead.


thanks,

Takashi