Re: Thinkpad with ALC1318 has a chance of damaging the IC

[Takashi Iwai <tiwai@suse.de>]

On Thu, 18 Apr 2024 08:33:42 +0200,
Kailang wrote:
> 
> Hi Takashi,
> 
> New patch was attached.
> new additional function was request from Lenovo.

I got a compile error.  The check should be rather

	if (codec->core.dev.power.power_state.event == PM_EVENT_FREEZE)

Maybe better to define is_s4_suspend() just like is_s4_resume().

And, please rebase the patch to the latest for-linus branch of
sound.git tree.


thanks,

Takashi

> 
> BR,
> Kailang
> 
> > -----Original Message-----
> > From: Takashi Iwai <tiwai@suse.de>
> > Sent: Thursday, April 18, 2024 2:22 PM
> > To: Kailang <kailang@realtek.com>
> > Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> > Subject: Re: Thinkpad with ALC1318 has a chance of damaging the IC
> > 
> > 
> > External mail.
> > 
> > 
> > 
> > On Mon, 15 Apr 2024 11:27:50 +0200,
> > Kailang wrote:
> > >
> > > Hi Takashi,
> > >
> > > Please don't apply this patch.
> > > They want to add stream open to enable GPIO3 functions.
> > 
> > OK, let me know if the new patch is ready.
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> > >
> > > BR,
> > > Kailang
> > >
> > > > -----Original Message-----
> > > > From: Kailang
> > > > Sent: Wednesday, April 10, 2024 5:23 PM
> > > > To: Takashi Iwai (tiwai@suse.de) <tiwai@suse.de>
> > > > Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> > > > Subject: Thinkpad with ALC1318 has a chance of damaging the IC
> > > >
> > > > Hi Takashi,
> > > >
> > > > Thinkpad with ALC1318 has a chance of damaging the IC at S4 resume.
> > > >
> > > > BR,
> > > > Kailang
>