From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Mark Brown <broonie@kernel.org>, Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: ASoC: new ac97 bus and codec clock
Date: Sun, 17 Jun 2018 22:03:54 +0200 [thread overview]
Message-ID: <87lgbdqixh.fsf@belgarion.home> (raw)
Hi Mark,
The new ac97 is working well in a platform data build. But in the device tree
case, there is an issue, triggered by our review in [1].
The main issue is the lack of one clock.
The device hierarchy is :
- platform device sound@40500000 (the AC97 controller)
\-> ac97 device sound@40500000:0 (the discovered ac97 IP for a wm9713)
Now the issue is here :
- sound/ac97/bus.c:419, function ac97_get_enable_clk()
- the clk_get() fails
The sound@40500000:0 device was automatically created by the AC97 bus code, but
I don't see any way to provide this device the "ac97_clk" ... How do you think
this is supposed to work, and how can my devicetree description provide this
clock ?
--
Robert
[1] Discussion reference
https://groups.google.com/forum/#!msg/linux.kernel/6_zIXK_maA4/RMYsmLlRMgAJ
Look for "You probably mean the BITCLK clock."
[2] Device tree extract
ac97: sound@40500000 {
compatible = "marvell,pxa270-ac97";
reg = < 0x40500000 0x1000 >;
interrupts = <14>;
reset-gpios = <&gpio 95 GPIO_ACTIVE_HIGH>;
#sound-dai-cells = <1>;
pinctrl-names = "default";
pinctrl-0 = < &pinctrl_ac97_default >;
clocks = <&clks CLK_AC97>, <&clks CLK_AC97CONF>;
clock-names = "AC97CLK", "AC97CONFCLK";
};
next reply other threads:[~2018-06-17 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 20:03 Robert Jarzmik [this message]
2018-06-19 15:02 ` ASoC: new ac97 bus and codec clock Mark Brown
2018-06-19 17:56 ` Rob Herring
2018-06-20 14:52 ` Robert Jarzmik
2018-06-20 15:10 ` Rob Herring
2018-06-20 17:04 ` Robert Jarzmik
2018-06-20 17:16 ` Rob Herring
2018-06-20 19:36 ` Robert Jarzmik
2018-06-20 20:00 ` Rob Herring
2018-06-27 11:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgbdqixh.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox