Re: ASoC: new ac97 bus and codec clock

[Robert Jarzmik <robert.jarzmik@free.fr>]

Rob Herring <robh+dt@kernel.org> writes:

> On Wed, Jun 20, 2018 at 8:52 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>> Rob Herring <robh+dt@kernel.org> writes:
Hi Rob,

>>         wm9713@0 {
>
> audio-codec@0
Sure.

>>                 reg = <0>; /* Codex index (between 0 and 3) */
>>                 compatible = "ac97-codec";
>
> This should be something with 'wm9713' in it or if there are ID
> registers you can base it on that.
Well, let's discuss that.
If I take as an example sdio, in mmc-card.txt, the compatible string is
"mmc-card", which describes the "kind" of subnode it is, not _exactly_ the
subnode it is.

If the purpose for this compatible string is to filter the child nodes which are
only ac97 codecs, so that the ac97 framework can act upon them (ie. acquire the
clock for example), then wm9713 is too specific ... That won't work for another
device with an Analog Devices AD1835 for example.

>>                 clocks = <&fixed_wm9713_clock>;
>>                 clock-names = "ac97_clk";
>
> This is the standard 12MHz clock?
Yes it is. The name comes from the original ac97 review, and is in
ac97_get_enable_clk().

Cheers.

-- 
Robert