Re: [PATCH v2] ALSA: hda/realtek: Add quirk for HP Dragonfly Folio G3 2-in-1 (103c:8a05)

[Takashi Iwai <tiwai@suse.de>]

On Mon, 27 Jul 2026 11:19:21 +0200,
Michael Diesen wrote:
> 
> The HP Dragonfly Folio G3 2-in-1 also ships with PCI SSID 103c:8a05.
> On this unit the ALC245 codec reports subsystem id 103c:8a06 - the SSID
> that is already covered by commit 0a10faad5ca5 ("ALSA: hda/realtek: add
> quirk for HP Dragonfly Folio G3 2-in-1") - while the PCI SSID that
> SND_PCI_QUIRK matches against is 103c:8a05:
> 
>   snd_hda_codec_alc269 ehdaudio0D0: ALC245: picked fixup for PCI SSID 103c:8a05
>   cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: CS35L41 Bound - SSID: 103C8A06
> 
> The existing entry therefore never applies here, the four CS35L41
> amplifiers on SPI are not registered and the internal speakers stay
> silent.
> 
> Add the same fixup that the 8a06 entry uses: the four amplifiers bind
> and the speaker mute LED (codec GPIO 0x04) works.
> 
> Signed-off-by: Michael Diesen <michael.diesen@posteo.de>
> ---
> v2:
>  - Resend using git send-email. v1 was mangled by my mail client (tabs
>    converted to spaces, long context lines soft-wrapped) so it could not
>    be applied with git am. Sorry for the noise, and thanks for the
>    pointer - I tested this one by mailing it to myself and applying it
>    with git am before sending.
>  - Use ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED instead of plain
>    ALC245_FIXUP_CS35L41_SPI_4. In v1 I claimed this was a non-2-in-1 SKU
>    that does not need the LED handling. That was wrong: DMI reports the
>    machine as "HP Dragonfly Folio G3 2-in-1", i.e. the same model as the
>    8a06 entry, and the speaker mute LED stayed dark with plain SPI_4.
>  - Name the entry identically to the 8a06 one, as it is the same machine
>    with a different PCI SSID.
> 
> On the mic-mute LED: alc285_fixup_hp_gpio_led() also drives GPIO 0x01 as
> mic-mute LED. That LED does not respond on this unit. Poking the codec
> GPIOs directly with hda-verb shows 0x04 toggling the speaker mute LED,
> while neither 0x01 nor 0x02 has any effect, so the mic-mute LED does not
> appear to be wired to the codec here. It does not work without the quirk
> either, so this is no regression, and it matches what the 8a06 entry
> already does - hence I kept the shared fixup instead of adding a new one.

Thanks, applied now.


Takashi