Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] ALSA: hda/realtek: simplify the return of comp_bind()
@ 2022-10-14  1:36 Yang Yingliang
  2022-10-17 11:10 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-10-14  1:36 UTC (permalink / raw)
  To: alsa-devel; +Cc: sbinding, tiwai, yangyingliang

After commit 23904f7b2518 ("ALSA: hda: cs35l41: Remove
suspend/resume hda hooks"), the return of comp_bind()
can be simplified. No functional changed.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 sound/pci/hda/patch_realtek.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e6c4bb5fa041..7c177426bf30 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6654,13 +6654,8 @@ static int comp_bind(struct device *dev)
 {
 	struct hda_codec *cdc = dev_to_hda_codec(dev);
 	struct alc_spec *spec = cdc->spec;
-	int ret;
 
-	ret = component_bind_all(dev, spec->comps);
-	if (ret)
-		return ret;
-
-	return 0;
+	return component_bind_all(dev, spec->comps);
 }
 
 static void comp_unbind(struct device *dev)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] ALSA: hda/realtek: simplify the return of comp_bind()
  2022-10-14  1:36 [PATCH -next] ALSA: hda/realtek: simplify the return of comp_bind() Yang Yingliang
@ 2022-10-17 11:10 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2022-10-17 11:10 UTC (permalink / raw)
  To: Yang Yingliang; +Cc: alsa-devel, tiwai, sbinding

On Fri, 14 Oct 2022 03:36:40 +0200,
Yang Yingliang wrote:
> 
> After commit 23904f7b2518 ("ALSA: hda: cs35l41: Remove
> suspend/resume hda hooks"), the return of comp_bind()
> can be simplified. No functional changed.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Applied now.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-17 11:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-14  1:36 [PATCH -next] ALSA: hda/realtek: simplify the return of comp_bind() Yang Yingliang
2022-10-17 11:10 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox