From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Simon <horms@verge.net.au>, Liam Girdwood <lgirdwood@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v2] ASoC: simple-card: cpu_dai_name creates confusion when DT case
Date: Thu, 27 Feb 2014 20:31:45 -0800 (PST) [thread overview]
Message-ID: <87ob1r97td.wl%kuninori.morimoto.gx@gmail.com> (raw)
In-Reply-To: <20140228035357.GL9383@sirena.org.uk>
Hi Mark
> > + * see
> > + * fmt_single_name()
> > + * fmt_multiple_name()
> > + */
> > + dai_link->cpu_dai_name = NULL;
> > +
>
> Why do this by overwriting rather than at the point where the variable
> gets assigned?
Do you mean why I did it end of asoc_simple_card_parse_of() ?
Because this cpu_dai_name itself is used for
dai_link->name, dai_link->stream_name;
This patch set NULL after that.
next prev parent reply other threads:[~2014-02-28 4:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 6:06 [PATCH] ASoC: simple-card: cpu_dai_name creates confusion when DT case Kuninori Morimoto
2014-02-27 5:07 ` Mark Brown
2014-02-27 10:21 ` Kuninori Morimoto
2014-02-28 2:25 ` [PATCH v2] " Kuninori Morimoto
2014-02-28 3:53 ` Mark Brown
2014-02-28 4:31 ` Kuninori Morimoto [this message]
2014-02-28 5:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob1r97td.wl%kuninori.morimoto.gx@gmail.com \
--to=kuninori.morimoto.gx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox