Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: john_candlish@mail.candlish.net
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] -- fix Boss MS-3 midi-usb communication
Date: Fri, 11 Aug 2023 09:36:18 +0200	[thread overview]
Message-ID: <87sf8qrpxp.wl-tiwai@suse.de> (raw)
In-Reply-To: <169173850488.20.12963803837559965998@mailman-web.alsa-project.org>

On Fri, 11 Aug 2023 09:21:44 +0200,
john_candlish@mail.candlish.net wrote:
> 
> This one line change gets MIDI communication flowing between ALSA and the Boss MS-3 multi-effect switcher.
> 
> /////
> *** sound/usb/midi.c    2023-08-10 22:46:31.016346930 +0200
> --- sound/usb/midi.c-orig   2023-07-19 16:37:03.000000000 +0200
> ***************
> *** 2106,2113 ****
>     struct usb_endpoint_descriptor *epd;
>     int i, out_eps = 0, in_eps = 0;
> 
> !   if (USB_ID_VENDOR(umidi->usb_id) == 0x0582 &&
> !       USB_ID_PRODUCT(umidi->usb_id) != 0x01f5)
>         snd_usbmidi_switch_roland_altsetting(umidi);
> 
> if (endpoint[0].out_ep || endpoint[0].in_ep)
> --- 2106,2112 ----
>     struct usb_endpoint_descriptor *epd;
>     int i, out_eps = 0, in_eps = 0;
> 
> !   if (USB_ID_VENDOR(umidi->usb_id) == 0x0582)
>         snd_usbmidi_switch_roland_altsetting(umidi);
> 
> if (endpoint[0].out_ep || endpoint[0].in_ep)
> 
> /////
> 
> There are doubtless other Roland/Boss USB_ID_PRODUCT id's that are effected and it would be nice to make the  USB_ID_PRODUCT value a tunable, but that is beyond my competence.

Could you give the exact USB vendor/product IDs so that I can cook a
patch?  At best, please give alsa-info.sh output; run the script with
--no-upload option and attach the output.


thanks,

Takashi


  reply	other threads:[~2023-08-11  7:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11  7:21 [PATCH] -- fix Boss MS-3 midi-usb communication john_candlish
2023-08-11  7:36 ` Takashi Iwai [this message]
2023-08-11  8:51   ` john_candlish
2023-08-16 11:47     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf8qrpxp.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=john_candlish@mail.candlish.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox