Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] ALSA: firewire-lib: fix uninitialized local variable
Date: Tue, 31 Jan 2023 09:33:03 +0100	[thread overview]
Message-ID: <87sffrp0hs.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230130141532.102838-1-o-takashi@sakamocchi.jp>

On Mon, 30 Jan 2023 15:15:32 +0100,
Takashi Sakamoto wrote:
> 
> The function local variable, curr_cycle_time is declared without
> initialization. When tracepoints event is not probed, it looks to be
> used as is. This commit fixes it. Fortunately, the value of local variable
> is not used unless the event is probed, thus this commit is for better
> coding.
> 
> Reported-by: Dan Carpenter <error27@gmail.com>
> Fixes: fef4e61b0b7 ("ALSA: firewire-lib: extend tracepoints event including CYCLE_TIME of 1394 OHCI")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Thanks, applied now (with the correction of Fixes tag).


Takashi

      reply	other threads:[~2023-01-31  8:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 14:15 [PATCH] ALSA: firewire-lib: fix uninitialized local variable Takashi Sakamoto
2023-01-31  8:33 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sffrp0hs.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=error27@gmail.com \
    --cc=o-takashi@sakamocchi.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox