From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH 0/2] ALSA: x86: intel_hdmi_audio: pm_runtime updates
Date: Fri, 17 Jun 2022 10:46:53 +0200 [thread overview]
Message-ID: <87sfo31xtu.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220616222910.136854-1-pierre-louis.bossart@linux.intel.com>
On Fri, 17 Jun 2022 00:29:08 +0200,
Pierre-Louis Bossart wrote:
>
> While cleaning up the code to use pm_runtime_resume_and_get(), I
> realized we never called pm_runtime_enable() for this driver. This is
> potentially very invasive and error-prone, so feedback and test
> results are welcome - all my BYT/CHT devices are not longer functional
> unfortunately, and our CI MinnowBoard uses the 'other' HDMI solution
> based on HDaudio.
>
> In addition, the resume was assumed to be always successful, which
> isn't a very good idea.
>
> Pierre-Louis Bossart (2):
> ALSA: x86: intel_hdmi_audio: enable pm_runtime and set autosuspend
> delay
> ALSA: x86: intel_hdmi_audio: use pm_runtime_resume_and_get()
Applied both patches now. Thanks.
Takashi
prev parent reply other threads:[~2022-06-17 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 22:29 [PATCH 0/2] ALSA: x86: intel_hdmi_audio: pm_runtime updates Pierre-Louis Bossart
2022-06-16 22:29 ` [PATCH 1/2] ALSA: x86: intel_hdmi_audio: enable pm_runtime and set autosuspend delay Pierre-Louis Bossart
2022-06-16 22:29 ` [PATCH 2/2] ALSA: x86: intel_hdmi_audio: use pm_runtime_resume_and_get() Pierre-Louis Bossart
2022-06-17 8:46 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfo31xtu.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox