From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/7] ALSA: emu10k1: drop redundant snd_emu10k1_efx_playback_hw_free()
Date: Sat, 22 Apr 2023 10:44:54 +0200 [thread overview]
Message-ID: <87ttx8papl.wl-tiwai@suse.de> (raw)
In-Reply-To: <87r0sdqo5n.wl-tiwai@suse.de>
On Fri, 21 Apr 2023 16:56:52 +0200,
Takashi Iwai wrote:
>
> On Fri, 21 Apr 2023 16:10:00 +0200,
> Oswald Buddenhagen wrote:
> >
> > Or actually, replace snd_emu10k1_playback_hw_free() with it, as that is
> > a subset.
> >
> > Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
>
> The code changes in the whole patch series look OK, but still a few
> minor corrections in the change logs (missing commit summary, etc) are
> needed.
>
> Also, when you submit this size of patch series, please make a cover
> letter and explain what the series are intended.
I applied applicable ones in the series (patches 1, 2, 3, 5, 7) now.
Please resubmit patches 4 and 6.
thanks,
Takashi
prev parent reply other threads:[~2023-04-22 8:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 14:10 [PATCH 1/7] ALSA: emu10k1: drop redundant snd_emu10k1_efx_playback_hw_free() Oswald Buddenhagen
2023-04-21 14:10 ` [PATCH 2/7] ALSA: emu10k1: drop redundant snd_emu10k1_efx_playback_pointer() Oswald Buddenhagen
2023-04-21 14:10 ` [PATCH 3/7] ALSA: emu10k1: remove obsolete card type variable and defines Oswald Buddenhagen
2023-04-21 14:10 ` [PATCH 4/7] ALSA: emu10k1: remove unused `resume` parameter from snd_emu10k1_init() Oswald Buddenhagen
2023-04-21 14:54 ` Takashi Iwai
2023-04-21 14:10 ` [PATCH 5/7] ALSA: emu10k1: remove unused snd_emu10k1_voice.emu field Oswald Buddenhagen
2023-04-21 14:10 ` [PATCH 6/7] ALSA: emu10k1: remove unused emu->pcm_playback_efx_substream field Oswald Buddenhagen
2023-04-21 14:54 ` Takashi Iwai
2023-04-21 15:00 ` Oswald Buddenhagen
2023-04-21 14:10 ` [PATCH 7/7] ALSA: emu10k1: clean up P16V part somewhat Oswald Buddenhagen
2023-04-21 14:56 ` [PATCH 1/7] ALSA: emu10k1: drop redundant snd_emu10k1_efx_playback_hw_free() Takashi Iwai
2023-04-21 15:16 ` Oswald Buddenhagen
2023-04-22 8:44 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttx8papl.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox