Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] sound: seq: fix typo in system_2p_ev_to_ump_midi1()
@ 2023-07-05  9:35 Minjie Du
  2023-07-05  9:52 ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Minjie Du @ 2023-07-05  9:35 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Minjie Du, Stephen Rothwell,
	moderated list:SOUND, open list
  Cc: opensource.kernel

Fix data->system.parm2 typo.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 sound/core/seq/seq_ump_convert.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c
index eb1d86ff6..7cc84e137 100644
--- a/sound/core/seq/seq_ump_convert.c
+++ b/sound/core/seq/seq_ump_convert.c
@@ -714,7 +714,7 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event,
 {
 	data->system.status = status;
 	data->system.parm1 = (event->data.control.value >> 7) & 0x7f;
-	data->system.parm1 = event->data.control.value & 0x7f;
+	data->system.parm2 = event->data.control.value & 0x7f;
 	return 1;
 }
 
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] sound: seq: fix typo in system_2p_ev_to_ump_midi1()
  2023-07-05  9:35 [PATCH v2] sound: seq: fix typo in system_2p_ev_to_ump_midi1() Minjie Du
@ 2023-07-05  9:52 ` Takashi Iwai
  2023-07-10 10:22   ` 回复: " 杜敏杰
  0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2023-07-05  9:52 UTC (permalink / raw)
  To: Minjie Du
  Cc: Jaroslav Kysela, Takashi Iwai, Stephen Rothwell,
	moderated list:SOUND, open list, opensource.kernel

On Wed, 05 Jul 2023 11:35:45 +0200,
Minjie Du wrote:
> 
> Fix data->system.parm2 typo.
> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>

Thanks, applied now.

At the next time, though, it'd be appreciated if you give the
corresponding Fixes tag, too.  I added manually for now.


Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* 回复: [PATCH v2] sound: seq: fix typo in system_2p_ev_to_ump_midi1()
  2023-07-05  9:52 ` Takashi Iwai
@ 2023-07-10 10:22   ` 杜敏杰
  0 siblings, 0 replies; 3+ messages in thread
From: 杜敏杰 @ 2023-07-10 10:22 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Jaroslav Kysela, Takashi Iwai, Stephen Rothwell,
	moderated list:SOUND, open list, opensource.kernel

> At the next time, though, it'd be appreciated if you give the corresponding Fixes tag, too.
Sorry it was my mistake, thanks

-----邮件原件-----
发件人: Takashi Iwai <tiwai@suse.de> 
发送时间: 2023年7月5日 17:53
收件人: 杜敏杰 <duminjie@vivo.com>
抄送: Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Stephen Rothwell <sfr@canb.auug.org.au>; moderated list:SOUND <alsa-devel@alsa-project.org>; open list <linux-kernel@vger.kernel.org>; opensource.kernel <opensource.kernel@vivo.com>
主题: Re: [PATCH v2] sound: seq: fix typo in system_2p_ev_to_ump_midi1()

[Some people who received this message don't often get email from tiwai@suse.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On Wed, 05 Jul 2023 11:35:45 +0200,
Minjie Du wrote:
>
> Fix data->system.parm2 typo.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>

Thanks, applied now.

At the next time, though, it'd be appreciated if you give the corresponding Fixes tag, too.  I added manually for now.


Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-10 15:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-05  9:35 [PATCH v2] sound: seq: fix typo in system_2p_ev_to_ump_midi1() Minjie Du
2023-07-05  9:52 ` Takashi Iwai
2023-07-10 10:22   ` 回复: " 杜敏杰

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox