Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jeeja KP <jeeja.kp@intel.com>, Vinod Koul <vinod.koul@intel.com>,
	Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Applied "ASoC: Intel: Skylake: Add DMA resume position in Trigger resume/suspend" to the asoc tree
Date: Sun, 10 Jan 2016 12:22:29 +0000	[thread overview]
Message-ID: <E1aIF0v-0008QP-S9@debutante> (raw)
In-Reply-To: <1449816267-11910-13-git-send-email-vinod.koul@intel.com>

The patch

   ASoC: Intel: Skylake: Add DMA resume position in Trigger resume/suspend

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 748a1d5a3fb75e1102320214a8bde347d7b228c3 Mon Sep 17 00:00:00 2001
From: Jeeja KP <jeeja.kp@intel.com>
Date: Fri, 18 Dec 2015 15:12:07 +0530
Subject: [PATCH] ASoC: Intel: Skylake: Add DMA resume position in Trigger
 resume/suspend

Use the DMA resume capability to resume the DMA position when
stream is suspended/resumed.

In suspend we save the position and when stream is resumed the stream needs
to be started from the position when the stream was suspended using the new
DMA resume capabilities

Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/intel/skylake/skl-pcm.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index 8039a0479053..5a532224cb47 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -393,6 +393,15 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
 	switch (cmd) {
 	case SNDRV_PCM_TRIGGER_RESUME:
 		skl_pcm_prepare(substream, dai);
+		/*
+		 * enable DMA Resume enable bit for the stream, set the dpib
+		 * & lpib position to resune before starting the DMA
+		 */
+		snd_hdac_ext_stream_drsm_enable(ebus, true,
+					hdac_stream(stream)->index);
+		snd_hdac_ext_stream_set_dpibr(ebus, stream, stream->dpib);
+		snd_hdac_ext_stream_set_lpib(stream, stream->lpib);
+
 	case SNDRV_PCM_TRIGGER_START:
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
 		/*
@@ -421,8 +430,17 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
 			return ret;
 
 		ret = skl_decoupled_trigger(substream, cmd);
-		if (cmd == SNDRV_PCM_TRIGGER_SUSPEND)
+		if (cmd == SNDRV_PCM_TRIGGER_SUSPEND) {
+			/* save the dpib and lpib positions */
+			stream->dpib = readl(ebus->bus.remap_addr +
+					AZX_REG_VS_SDXDPIB_XBASE +
+					(AZX_REG_VS_SDXDPIB_XINTERVAL *
+					hdac_stream(stream)->index));
+
+			stream->lpib = snd_hdac_stream_get_pos_lpib(
+							hdac_stream(stream));
 			snd_hdac_ext_stream_decouple(ebus, stream, false);
+		}
 		break;
 
 	default:
-- 
2.7.0.rc3

  reply	other threads:[~2016-01-10 12:22 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  6:44 [PATCH 00/14] ASoC: Intel: Skylake: Update to SKL driver Vinod Koul
2015-12-11  6:44 ` [PATCH 01/14] ASoC: Intel: Skylake: Clear stream registers before stream setup Vinod Koul
2015-12-18 17:14   ` Applied "ASoC: Intel: Skylake: Clear stream registers before stream setup" to the asoc tree Mark Brown
2015-12-11  6:44 ` [PATCH 02/14] ASoC: Intel: Skylake: Fix to set pipe state to invalid when deleting Vinod Koul
2015-12-18 17:14   ` Applied "ASoC: Intel: Skylake: Fix to set pipe state to invalid when deleting" to the asoc tree Mark Brown
2015-12-11  6:44 ` [PATCH 03/14] ALSA: hdac: Add support for hda DMA Resume capability Vinod Koul
2016-01-10 12:07   ` Applied "ALSA: hdac: Add support for hda DMA Resume capability" to the asoc tree Mark Brown
2015-12-11  6:44 ` [PATCH 04/14] ALSA: hdac: couple the hda DMA stream in cleanup Vinod Koul
2016-01-10 12:07   ` Applied "ALSA: hdac: couple the hda DMA stream in cleanup" to the asoc tree Mark Brown
2015-12-11  6:44 ` [PATCH 05/14] ALSA: hdac: Add MISCBDCGE support Vinod Koul
2015-12-11  8:54   ` Takashi Iwai
2015-12-11  9:25     ` Vinod Koul
2015-12-11  9:51       ` Takashi Iwai
     [not found]   ` <201512120531.wHapk8nX%fengguang.wu@intel.com>
2015-12-12 11:43     ` Vinod Koul
2015-12-11  6:44 ` [PATCH 06/14] ALSA: hdac: Increase timeout value for link power check Vinod Koul
2016-01-10 12:07   ` Applied "ALSA: hdac: Increase timeout value for link power check" to the asoc tree Mark Brown
2015-12-11  6:44 ` [PATCH 07/14] ALSA: hdac: add snd_hdac_ext_bus_link_power_up_all Vinod Koul
2016-01-10 12:07   ` Applied "ALSA: hdac: add snd_hdac_ext_bus_link_power_up_all" to the asoc tree Mark Brown
2015-12-11  6:44 ` [PATCH 08/14] ASoC: Intel: Skylake: fix reset controller sequencing Vinod Koul
2015-12-11  6:44 ` [PATCH 09/14] ASoC: Intel: Skylake: Use CGCTL.MISCBDCGE for Phrase detection notification Vinod Koul
2015-12-11  6:44 ` [PATCH 10/14] ASoC: Intel: Skylake: manage link power in active suspend Vinod Koul
2016-01-10 12:22   ` Applied "ASoC: Intel: Skylake: manage link power in active suspend" to the asoc tree Mark Brown
2015-12-11  6:44 ` [PATCH 11/14] ASoC: Intel: Skylake: enable interrupt as wake source in active suspend Vinod Koul
2016-01-10 12:22   ` Applied "ASoC: Intel: Skylake: enable interrupt as wake source in active suspend" to the asoc tree Mark Brown
2015-12-11  6:44 ` [PATCH 12/14] ASoC: Intel: Skylake: Add DMA resume position in Trigger resume/suspend Vinod Koul
2016-01-10 12:22   ` Mark Brown [this message]
2015-12-11  6:44 ` [PATCH 13/14] ASoC: Intel: Skylake: Reconfigure Link stream on suspend/resume Vinod Koul
2016-01-10 12:22   ` Applied "ASoC: Intel: Skylake: Reconfigure Link stream on suspend/resume" to the asoc tree Mark Brown
2015-12-11  6:44 ` [PATCH 14/14] ASoC: Intel: Skylake: Add Resume capability in PCM info Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1aIF0v-0008QP-S9@debutante \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=jeeja.kp@intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox