Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: codecs: wm8753: Replace magic number
@ 2016-06-25  4:58 Alexander Shiyan
  2016-06-26  1:18 ` Mark Brown
  2016-06-26 12:02 ` Applied "ASoC: wm8753: Replace magic number" to the asoc tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Shiyan @ 2016-06-25  4:58 UTC (permalink / raw)
  To: alsa-devel
  Cc: Alexander Shiyan, patches, Takashi Iwai, Liam Girdwood,
	Mark Brown

Use SND_SOC_NOPM constant, instead of -1.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 sound/soc/codecs/wm8753.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
index 6f1024f..9f851b8 100644
--- a/sound/soc/codecs/wm8753.c
+++ b/sound/soc/codecs/wm8753.c
@@ -486,7 +486,7 @@ SND_SOC_DAPM_DAC("Voice DAC", "Voice Playback", WM8753_PWR1, 4, 0),
 SND_SOC_DAPM_OUTPUT("MONO1"),
 SND_SOC_DAPM_MUX("Mono 2 Mux", SND_SOC_NOPM, 0, 0, &wm8753_mono2_controls),
 SND_SOC_DAPM_OUTPUT("MONO2"),
-SND_SOC_DAPM_MIXER("Out3 Left + Right", -1, 0, 0, NULL, 0),
+SND_SOC_DAPM_MIXER("Out3 Left + Right", SND_SOC_NOPM, 0, 0, NULL, 0),
 SND_SOC_DAPM_MUX("Out3 Mux", SND_SOC_NOPM, 0, 0, &wm8753_out3_controls),
 SND_SOC_DAPM_PGA("Out 3", WM8753_PWR3, 4, 0, NULL, 0),
 SND_SOC_DAPM_OUTPUT("OUT3"),
-- 
2.4.9

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ASoC: codecs: wm8753: Replace magic number
  2016-06-25  4:58 [PATCH 1/2] ASoC: codecs: wm8753: Replace magic number Alexander Shiyan
@ 2016-06-26  1:18 ` Mark Brown
  2016-06-26 12:02 ` Applied "ASoC: wm8753: Replace magic number" to the asoc tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2016-06-26  1:18 UTC (permalink / raw)
  To: Alexander Shiyan; +Cc: patches, alsa-devel, Takashi Iwai, Liam Girdwood


[-- Attachment #1.1: Type: text/plain, Size: 256 bytes --]

On Sat, Jun 25, 2016 at 07:58:09AM +0300, Alexander Shiyan wrote:
> Use SND_SOC_NOPM constant, instead of -1.

Please submit patches using subject lines reflecting the style for the
subsystem.  This makes it easier for people to identify relevant
patches.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "ASoC: wm8753: Replace magic number" to the asoc tree
  2016-06-25  4:58 [PATCH 1/2] ASoC: codecs: wm8753: Replace magic number Alexander Shiyan
  2016-06-26  1:18 ` Mark Brown
@ 2016-06-26 12:02 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2016-06-26 12:02 UTC (permalink / raw)
  To: Alexander Shiyan
  Cc: Liam Girdwood, alsa-devel, Mark Brown, patches, Takashi Iwai

The patch

   ASoC: wm8753: Replace magic number

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From eb87f9e2b3212c84498c6972b529e207e4e95e6a Mon Sep 17 00:00:00 2001
From: Alexander Shiyan <shc_work@mail.ru>
Date: Sat, 25 Jun 2016 07:58:09 +0300
Subject: [PATCH] ASoC: wm8753: Replace magic number

Use SND_SOC_NOPM constant, instead of -1.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/wm8753.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
index b4e6893f5e3d..cdcc91282e8a 100644
--- a/sound/soc/codecs/wm8753.c
+++ b/sound/soc/codecs/wm8753.c
@@ -485,7 +485,7 @@ SND_SOC_DAPM_DAC("Voice DAC", "Voice Playback", WM8753_PWR1, 4, 0),
 SND_SOC_DAPM_OUTPUT("MONO1"),
 SND_SOC_DAPM_MUX("Mono 2 Mux", SND_SOC_NOPM, 0, 0, &wm8753_mono2_controls),
 SND_SOC_DAPM_OUTPUT("MONO2"),
-SND_SOC_DAPM_MIXER("Out3 Left + Right", -1, 0, 0, NULL, 0),
+SND_SOC_DAPM_MIXER("Out3 Left + Right", SND_SOC_NOPM, 0, 0, NULL, 0),
 SND_SOC_DAPM_MUX("Out3 Mux", SND_SOC_NOPM, 0, 0, &wm8753_out3_controls),
 SND_SOC_DAPM_PGA("Out 3", WM8753_PWR3, 4, 0, NULL, 0),
 SND_SOC_DAPM_OUTPUT("OUT3"),
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-26 12:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-25  4:58 [PATCH 1/2] ASoC: codecs: wm8753: Replace magic number Alexander Shiyan
2016-06-26  1:18 ` Mark Brown
2016-06-26 12:02 ` Applied "ASoC: wm8753: Replace magic number" to the asoc tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox