From: Stephan Gerhold <stephan@gerhold.net>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Cheng-Yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCH] ASoC: hdmi-codec: Fix return value in hdmi_codec_set_jack()
Date: Thu, 7 Jan 2021 17:47:16 +0100 [thread overview]
Message-ID: <X/c7B5c382TV/f76@gerhold.net> (raw)
In-Reply-To: <20210107163600.GE4726@sirena.org.uk>
On Thu, Jan 07, 2021 at 04:36:00PM +0000, Mark Brown wrote:
> On Thu, Jan 07, 2021 at 05:26:40PM +0100, Stephan Gerhold wrote:
>
> > However, hdmi_codec_set_jack() returns -E*OP*NOTSUPP if jack detection
> > is not supported, which is not handled in apq8016_sbc and soc_component_ret().
> > Make it return -ENOTSUPP instead to fix sound and silence the errors.
>
> You will also need to update imx-hdmi, it is explicitly checking for
> -EOPNOTSUPP so this will break it. Having two error codes with such
> similar names is rather unfortunate.
Right, thanks for mentioning this! Apparently I only checked 5.10 for
other uses of -EOPNOTSUPP... Will send a v2 shortly!
Thanks,
Stephan
prev parent reply other threads:[~2021-01-07 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 16:26 [PATCH] ASoC: hdmi-codec: Fix return value in hdmi_codec_set_jack() Stephan Gerhold
2021-01-07 16:36 ` Mark Brown
2021-01-07 16:47 ` Stephan Gerhold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/c7B5c382TV/f76@gerhold.net \
--to=stephan@gerhold.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox