From: Mark Brown <broonie@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] ASoC: samsung: remove DMA filter function and data
Date: Thu, 19 Jan 2023 16:59:00 +0000 [thread overview]
Message-ID: <Y8l21Kb42l2ZcIC+@sirena.org.uk> (raw)
In-Reply-To: <20230118161110.521504-1-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]
On Wed, Jan 18, 2023 at 05:10:45PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This data is no longer passed by the platform code, so
> there is no point passing it down at all.
This breaks an x86 allmodconfig build:
/build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c: In function ‘s3c24xx_iis_dev_probe’:
/build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c:436:56: error: passing argument 4 of ‘samsung_asoc_dma_platform_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
436 | "tx", "rx", NULL);
| ^~~~
| |
| char *
In file included from /build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c:21:
/build/stage/linux/sound/soc/samsung/dma.h:17:55: note: expected ‘struct device *’ but argument is of type ‘char *’
17 | struct device *dma_dev);
| ~~~~~~~~~~~~~~~^~~~~~~
/build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c:435:15: error: too many arguments to function ‘samsung_asoc_dma_platform_register’
435 | ret = samsung_asoc_dma_platform_register(&pdev->dev, NULL,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/samsung/dma.h:15:5: note: declared here
15 | int samsung_asoc_dma_platform_register(struct device *dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-19 17:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 16:10 [PATCH 1/5] ASoC: samsung: remove DMA filter function and data Arnd Bergmann
2023-01-18 16:10 ` [PATCH 2/5] ASoC: pxa: remove snd_dmaengine_pcm_open_request_chan() Arnd Bergmann
2023-01-19 16:56 ` Mark Brown
2023-01-18 16:10 ` [PATCH 3/5] ASoC: ux500: remove platform_data support Arnd Bergmann
2023-01-18 22:32 ` Linus Walleij
2023-01-18 16:10 ` [PATCH 4/5] ASoC: ux500: remove stedma40 references Arnd Bergmann
2023-01-18 22:34 ` Linus Walleij
2023-01-18 16:10 ` [PATCH 5/5] ASoC: remove snd_dmaengine_pcm_config->compat_request_channel Arnd Bergmann
2023-01-19 15:39 ` [PATCH 1/5] ASoC: samsung: remove DMA filter function and data Krzysztof Kozlowski
2023-01-19 16:59 ` Mark Brown [this message]
2023-01-20 9:05 ` Arnd Bergmann
2023-01-20 12:07 ` Mark Brown
2023-01-20 12:29 ` Arnd Bergmann
2023-01-20 22:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8l21Kb42l2ZcIC+@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox