From: Mark Brown <broonie@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: alsa-devel@alsa-project.org, tangmeng@uniontech.com,
Abaci Robot <abaci@linux.alibaba.com>,
tiwai@suse.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq_byname()
Date: Tue, 1 Mar 2022 12:39:52 +0000 [thread overview]
Message-ID: <Yh4UGGuspsc/gAyY@sirena.org.uk> (raw)
In-Reply-To: <20220301064920.37788-1-yang.lee@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
On Tue, Mar 01, 2022 at 02:49:20PM +0800, Yang Li wrote:
> - adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq");
> - if (adata->i2s_irq < 0)
> + adata->i2s_irq = ret = platform_get_irq_byname(pdev, "acp_dai_irq");
> + if (ret < 0)
> return -ENODEV;
If an error code is being returned we should report that error code
rather than squashing it down to -ENODEV.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-01 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 6:49 [PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq_byname() Yang Li
2022-03-01 12:39 ` Mark Brown [this message]
2022-03-02 1:17 ` 回复：[PATCH " Yang.Lee
2022-03-02 13:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh4UGGuspsc/gAyY@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tangmeng@uniontech.com \
--cc=tiwai@suse.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox