From: Mark Brown <broonie@kernel.org>
To: "Yang.Lee" <yang.lee@linux.alibaba.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
tangmeng <tangmeng@uniontech.com>,
Abaci Robot <abaci@linux.alibaba.com>, tiwai <tiwai@suse.com>,
lgirdwood <lgirdwood@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 回复：[PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq_byname()
Date: Wed, 2 Mar 2022 13:11:45 +0000 [thread overview]
Message-ID: <Yh9tEYtfKTBIICQS@sirena.org.uk> (raw)
In-Reply-To: <53306907-c963-4740-9a90-c1249ba0dff4.yang.lee@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
On Wed, Mar 02, 2022 at 09:17:21AM +0800, Yang.Lee wrote:
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
> The function dev_err_probe() is called in function platform_get_irq_byname() to print the error code.
That doesn't seem at all relevant to the error code being returned which
is what the review feedback was about:
> > If an error code is being returned we should report that error code
> > rather than squashing it down to -ENODEV.
Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-03-02 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 6:49 [PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq_byname() Yang Li
2022-03-01 12:39 ` Mark Brown
2022-03-02 1:17 ` 回复：[PATCH " Yang.Lee
2022-03-02 13:11 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh9tEYtfKTBIICQS@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tangmeng@uniontech.com \
--cc=tiwai@suse.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox