[PATCH 0/3] Update dt-bindings for sc7280 platform

[PATCH 0/3] Update dt-bindings for sc7280 platform

[Srinivasa Rao Mandadapu]

This patch set is to update required clocks, power domain names for sc7280 platforms,
and add mic bias supply for wcd938x codec.

Srinivasa Rao Mandadapu (3):
  ASoC: qcom: dt-bindings: Update bindings for clocks in lpass digital
    codes
  ASoC: dt-bindings: wcd938x: Add mic bias supply property
  ASoC: dt-bindings: lpass-cpu: Update clocks and power domain names for
    sc7280 platform

 .../devicetree/bindings/sound/qcom,lpass-cpu.yaml       | 17 ++++++++++++++---
 .../devicetree/bindings/sound/qcom,lpass-rx-macro.yaml  | 17 +++++++++++------
 .../devicetree/bindings/sound/qcom,lpass-tx-macro.yaml  | 17 +++++++++++------
 .../devicetree/bindings/sound/qcom,lpass-va-macro.yaml  | 11 +++++++----
 .../devicetree/bindings/sound/qcom,wcd938x.yaml         |  3 +++
 5 files changed, 46 insertions(+), 19 deletions(-)

-- 
2.7.4

[PATCH 1/3] ASoC: qcom: dt-bindings: Update bindings for clocks in lpass digital codes

[Srinivasa Rao Mandadapu]

Update dt-bindings for clocks as per ADSP bypass solutions, in which macro
dcodec GDSCs are enabled using power domains in lpass digital codec drivers.

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
 .../devicetree/bindings/sound/qcom,lpass-rx-macro.yaml  | 17 +++++++++++------
 .../devicetree/bindings/sound/qcom,lpass-tx-macro.yaml  | 17 +++++++++++------
 .../devicetree/bindings/sound/qcom,lpass-va-macro.yaml  | 11 +++++++----
 3 files changed, 29 insertions(+), 16 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
index 6127df5..a6905bc 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
@@ -28,12 +28,17 @@ properties:
     maxItems: 5
 
   clock-names:
-    items:
-      - const: mclk
-      - const: npl
-      - const: macro
-      - const: dcodec
-      - const: fsgen
+    oneOf:
+      - items:   #for ADSP based platforms
+          - const: mclk
+          - const: npl
+          - const: macro
+          - const: dcodec
+          - const: fsgen
+      - items:   #for ADSP bypass based platforms
+          - const: mclk
+          - const: npl
+          - const: fsgen
 
   clock-output-names:
     items:
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
index 3f0f99c..324595a 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
@@ -28,12 +28,17 @@ properties:
     maxItems: 5
 
   clock-names:
-    items:
-      - const: mclk
-      - const: npl
-      - const: macro
-      - const: dcodec
-      - const: fsgen
+    oneOf:
+      - items:   #for ADSP based platforms
+          - const: mclk
+          - const: npl
+          - const: macro
+          - const: dcodec
+          - const: fsgen
+      - items:   #for ADSP bypass based platforms
+          - const: mclk
+          - const: npl
+          - const: fsgen
 
   clock-output-names:
     items:
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
index 9868a5e..7b4cc84 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
@@ -28,10 +28,13 @@ properties:
     maxItems: 3
 
   clock-names:
-    items:
-      - const: mclk
-      - const: core
-      - const: dcodec
+    oneOf:
+      - items:   #for ADSP based platforms
+          - const: mclk
+          - const: core
+          - const: dcodec
+      - items:   #for ADSP bypass based platforms
+          - const: mclk
 
   clock-output-names:
     items:
-- 
2.7.4

Re: [PATCH 1/3] ASoC: qcom: dt-bindings: Update bindings for clocks in lpass digital codes

[Rob Herring]

On Mon, 21 Mar 2022 14:26:19 +0530, Srinivasa Rao Mandadapu wrote:
> Update dt-bindings for clocks as per ADSP bypass solutions, in which macro
> dcodec GDSCs are enabled using power domains in lpass digital codec drivers.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
>  .../devicetree/bindings/sound/qcom,lpass-rx-macro.yaml  | 17 +++++++++++------
>  .../devicetree/bindings/sound/qcom,lpass-tx-macro.yaml  | 17 +++++++++++------
>  .../devicetree/bindings/sound/qcom,lpass-va-macro.yaml  | 11 +++++++----
>  3 files changed, 29 insertions(+), 16 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

[PATCH 2/3] ASoC: dt-bindings: wcd938x: Add mic bias supply property

[Srinivasa Rao Mandadapu]

Add vdd mic bias supply, which is required to provide bias
for wcd938x codec.

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
 Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
index 7bf1a5f..5154719 100644
--- a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
@@ -36,6 +36,9 @@ properties:
   vdd-io-supply:
     description: A reference to the 1.8V I/O supply
 
+  vdd-mic-bias-supply:
+    description: A reference to the 3.8V mic bias supply
+
   qcom,tx-device:
     $ref: /schemas/types.yaml#/definitions/phandle-array
     description: A reference to Soundwire tx device phandle
-- 
2.7.4

Re: [PATCH 2/3] ASoC: dt-bindings: wcd938x: Add mic bias supply property

[Rob Herring]

On Mon, 21 Mar 2022 14:26:20 +0530, Srinivasa Rao Mandadapu wrote:
> Add vdd mic bias supply, which is required to provide bias
> for wcd938x codec.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
>  Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

[PATCH 3/3] ASoC: dt-bindings: lpass-cpu: Update clocks and power domain names for sc7280 platform

[Srinivasa Rao Mandadapu]

Update required clock-names used for MI2S primary path, VA macro's
codec memory path and HDMI path in sc7280 based platforms.
Update power domain names required for sc7280 platforms.

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
 .../devicetree/bindings/sound/qcom,lpass-cpu.yaml       | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
index 2c81efb..e9a5330 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
@@ -38,8 +38,8 @@ properties:
     maxItems: 7
 
   clock-names:
-    minItems: 3
-    maxItems: 7
+    minItems: 1
+    maxItems: 10
 
   interrupts:
     minItems: 2
@@ -62,6 +62,9 @@ properties:
   power-domains:
     maxItems: 1
 
+  power-domain-names:
+    maxItems: 1
+
   '#sound-dai-cells':
     const: 1
 
@@ -192,15 +195,19 @@ allOf:
           oneOf:
             - items:   #for I2S
                 - const: aon_cc_audio_hm_h
+                - const: audio_cc_ext_mclk0
                 - const: core_cc_sysnoc_mport_core
+                - const: core_cc_ext_if0_ibit
                 - const: core_cc_ext_if1_ibit
             - items:   #for Soundwire
                 - const: aon_cc_audio_hm_h
+                - const: audio_cc_codec_mem
                 - const: audio_cc_codec_mem0
                 - const: audio_cc_codec_mem1
                 - const: audio_cc_codec_mem2
+                - const: aon_cc_va_mem0
             - items:   #for HDMI
-                - const: aon_cc_audio_hm_h
+                - const: core_cc_sysnoc_mport_core
 
         reg-names:
           anyOf:
@@ -228,6 +235,10 @@ allOf:
                 - const: lpass-irq-hdmi
                 - const: lpass-irq-vaif
                 - const: lpass-irq-rxtxif
+        power-domain-names:
+          allOf:
+            - items:
+                - const: lcx
 
       required:
         - iommus
-- 
2.7.4

Re: [PATCH 3/3] ASoC: dt-bindings: lpass-cpu: Update clocks and power domain names for sc7280 platform

[Rob Herring]

On Mon, Mar 21, 2022 at 02:26:21PM +0530, Srinivasa Rao Mandadapu wrote:
> Update required clock-names used for MI2S primary path, VA macro's
> codec memory path and HDMI path in sc7280 based platforms.
> Update power domain names required for sc7280 platforms.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
>  .../devicetree/bindings/sound/qcom,lpass-cpu.yaml       | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> index 2c81efb..e9a5330 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> @@ -38,8 +38,8 @@ properties:
>      maxItems: 7
>  
>    clock-names:
> -    minItems: 3
> -    maxItems: 7
> +    minItems: 1
> +    maxItems: 10
>  
>    interrupts:
>      minItems: 2
> @@ -62,6 +62,9 @@ properties:
>    power-domains:
>      maxItems: 1
>  
> +  power-domain-names:
> +    maxItems: 1
> +
>    '#sound-dai-cells':
>      const: 1
>  
> @@ -192,15 +195,19 @@ allOf:
>            oneOf:
>              - items:   #for I2S
>                  - const: aon_cc_audio_hm_h
> +                - const: audio_cc_ext_mclk0
>                  - const: core_cc_sysnoc_mport_core
> +                - const: core_cc_ext_if0_ibit
>                  - const: core_cc_ext_if1_ibit

You can't add new clocks in the middle. That breaks the ABI.

>              - items:   #for Soundwire
>                  - const: aon_cc_audio_hm_h
> +                - const: audio_cc_codec_mem
>                  - const: audio_cc_codec_mem0
>                  - const: audio_cc_codec_mem1
>                  - const: audio_cc_codec_mem2
> +                - const: aon_cc_va_mem0
>              - items:   #for HDMI
> -                - const: aon_cc_audio_hm_h
> +                - const: core_cc_sysnoc_mport_core
>  
>          reg-names:
>            anyOf:
> @@ -228,6 +235,10 @@ allOf:
>                  - const: lpass-irq-hdmi
>                  - const: lpass-irq-vaif
>                  - const: lpass-irq-rxtxif
> +        power-domain-names:
> +          allOf:
> +            - items:
> +                - const: lcx
>  
>        required:
>          - iommus
> -- 
> 2.7.4
> 
> 

Re: [PATCH 0/3] Update dt-bindings for sc7280 platform

[Mark Brown]

On Mon, 21 Mar 2022 14:26:18 +0530, Srinivasa Rao Mandadapu wrote:
> This patch set is to update required clocks, power domain names for sc7280 platforms,
> and add mic bias supply for wcd938x codec.
> 
> Srinivasa Rao Mandadapu (3):
>   ASoC: qcom: dt-bindings: Update bindings for clocks in lpass digital
>     codes
>   ASoC: dt-bindings: wcd938x: Add mic bias supply property
>   ASoC: dt-bindings: lpass-cpu: Update clocks and power domain names for
>     sc7280 platform
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: qcom: dt-bindings: Update bindings for clocks in lpass digital codes
      commit: 852fda58d99a6c397f8303a8cd8ccec8702d82f5
[2/3] ASoC: dt-bindings: wcd938x: Add mic bias supply property
      commit: 9108c3446f6e86146f0d3141b94415eb98c39566
[3/3] ASoC: dt-bindings: lpass-cpu: Update clocks and power domain names for sc7280 platform
      commit: 98b7630a583fe970f59742dc855d1c03e258d645

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark