From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH] ALSA: emu10k1: fix multi-channel playback device class
Date: Tue, 25 Apr 2023 10:00:45 +0200 [thread overview]
Message-ID: <ZEeIrTZeEDHxwwAZ@ugly> (raw)
In-Reply-To: <ZEZa2oQV20IgqNvR@ugly>
On Mon, Apr 24, 2023 at 12:32:58PM +0200, Oswald Buddenhagen wrote:
>so i'd postulate that these enums are effectively dead, and both the
>risk and the gain of this change are about zero.
speaking of dead code, lots of drivers explicitly assign info_flags = 0,
dev_class = SNDRV_PCM_CLASS_GENERIC, and dev_subclass =
SNDRV_PCM_SUBCLASS_GENERIC_MIX, which are all technically pointless, as
the pcm struct is kzalloc'd anyway. and of course it's entirely
inconsistent (with just about every combination present), because it
obviously works without this. how would you feel about a patch that just
removes all these?
regards
next prev parent reply other threads:[~2023-04-25 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 16:10 [PATCH] ALSA: emu10k1: fix multi-channel playback device class Oswald Buddenhagen
2023-04-23 7:30 ` Takashi Iwai
2023-04-24 10:32 ` Oswald Buddenhagen
2023-04-25 8:00 ` Oswald Buddenhagen [this message]
2023-04-25 8:15 ` Takashi Iwai
2023-04-25 8:29 ` Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEeIrTZeEDHxwwAZ@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox