From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 02/13] PCI: Add Intel Audio DSP devices to pci_ids.h
Date: Tue, 11 Jul 2023 16:33:00 +0300 [thread overview]
Message-ID: <ZK1aDMZg+I/Dheo6@smile.fi.intel.com> (raw)
In-Reply-To: <20230711125726.3509391-3-amadeuszx.slawinski@linux.intel.com>
On Tue, Jul 11, 2023 at 02:57:15PM +0200, Amadeusz Sławiński wrote:
> Those IDs are mostly sprinkled between HDA, Skylake, SOF and avs drivers.
> Almost every use contains additional comments to identify to which
> platform those IDs refer to. Add those IDs to pci_ids.h header, so that
> there is one place which defines those names.
>From style looks good to me, but I think somebody from ASoC/sound needs to
carefully check HDA/non-HDA/etc.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> # for the Intel Tangier ID
> Acked-by: Mark Brown <broonie@kernel.org>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-11 13:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 12:57 [PATCH 00/13] PCI: Define Intel PCI IDs and use them in drivers Amadeusz Sławiński
2023-07-11 12:57 ` [PATCH 01/13] PCI: Sort Intel PCI IDs by number Amadeusz Sławiński
2023-07-11 13:30 ` Andy Shevchenko
2023-07-11 16:17 ` Bjorn Helgaas
2023-07-11 12:57 ` [PATCH 02/13] PCI: Add Intel Audio DSP devices to pci_ids.h Amadeusz Sławiński
2023-07-11 13:33 ` Andy Shevchenko [this message]
2023-07-11 12:57 ` [PATCH 03/13] ALSA: hda: Add controller matching macros Amadeusz Sławiński
2023-07-11 13:36 ` Andy Shevchenko
2023-07-12 10:54 ` Amadeusz Sławiński
2023-07-11 12:57 ` [PATCH 04/13] ALSA: hda: Use global PCI match macro Amadeusz Sławiński
2023-07-11 13:37 ` Andy Shevchenko
2023-07-11 12:57 ` [PATCH 05/13] ALSA: hda/i915: " Amadeusz Sławiński
2023-07-11 13:39 ` Andy Shevchenko
2023-07-11 12:57 ` [PATCH 06/13] ASoC: Intel: Skylake: " Amadeusz Sławiński
2023-07-11 13:41 ` Andy Shevchenko
2023-07-11 12:57 ` [PATCH 07/13] ALSA: intel-dsp-config: Convert to PCI device IDs defines Amadeusz Sławiński
2023-07-11 14:00 ` Andy Shevchenko
2023-07-11 14:09 ` Amadeusz Sławiński
2023-07-11 14:12 ` Andy Shevchenko
2023-07-11 12:57 ` [PATCH 08/13] ALSA: hda: " Amadeusz Sławiński
2023-07-11 14:07 ` Andy Shevchenko
2023-07-12 11:22 ` Amadeusz Sławiński
2023-07-12 11:28 ` Takashi Iwai
2023-07-11 12:57 ` [PATCH 09/13] ASoC: Intel: avs: " Amadeusz Sławiński
2023-07-11 14:02 ` Andy Shevchenko
2023-07-11 12:57 ` [PATCH 10/13] " Amadeusz Sławiński
2023-07-11 14:09 ` Andy Shevchenko
2023-07-11 14:13 ` Amadeusz Sławiński
2023-07-11 12:57 ` [PATCH 11/13] ASoC: Intel: Skylake: " Amadeusz Sławiński
2023-07-11 14:10 ` Andy Shevchenko
2023-07-11 12:57 ` [PATCH 12/13] ASoC: SOF: Intel: " Amadeusz Sławiński
2023-07-11 14:16 ` Andy Shevchenko
2023-07-12 12:16 ` Amadeusz Sławiński
2023-07-12 15:53 ` Andy Shevchenko
2023-07-11 12:57 ` [PATCH 13/13] ASoC: Intel: sst: " Amadeusz Sławiński
2023-07-11 14:33 ` Andy Shevchenko
2023-07-12 12:19 ` Amadeusz Sławiński
2023-07-12 15:54 ` Andy Shevchenko
2023-07-11 15:24 ` [PATCH 00/13] PCI: Define Intel PCI IDs and use them in drivers Pierre-Louis Bossart
2023-07-11 15:36 ` Mark Brown
2023-07-11 15:42 ` Takashi Iwai
2023-07-11 15:58 ` Mark Brown
2023-07-11 16:19 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK1aDMZg+I/Dheo6@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox