From: Vinod Koul <vkoul@kernel.org>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] soundwire: Use snd_soc_substream_to_rtd() to obtain rtd
Date: Mon, 16 Oct 2023 16:50:32 +0530 [thread overview]
Message-ID: <ZS0cgDqsyEW86RSZ@matsya> (raw)
In-Reply-To: <20230929105546.774332-1-amadeuszx.slawinski@linux.intel.com>
On 29-09-23, 12:55, Amadeusz Sławiński wrote:
> From: Cezary Rojewski <cezary.rojewski@intel.com>
>
> Utilize the helper function instead of casting from ->private_data
> directly.
>
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
> ---
> drivers/soundwire/stream.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
> index 69719b335bcb..652aae4e221d 100644
> --- a/drivers/soundwire/stream.c
> +++ b/drivers/soundwire/stream.c
> @@ -1717,7 +1717,7 @@ EXPORT_SYMBOL(sdw_deprepare_stream);
> static int set_stream(struct snd_pcm_substream *substream,
> struct sdw_stream_runtime *sdw_stream)
> {
> - struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
This does not exist for me, so I guess you can resend it after next
cycle when this appears in rc1
--
~Vinod
next prev parent reply other threads:[~2023-10-16 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 10:55 [PATCH] soundwire: Use snd_soc_substream_to_rtd() to obtain rtd Amadeusz Sławiński
2023-10-16 11:20 ` Vinod Koul [this message]
2024-03-03 14:01 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2024-02-19 10:52 Cezary Rojewski
2024-03-03 14:01 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS0cgDqsyEW86RSZ@matsya \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=cezary.rojewski@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox