Re: [PATCH] ALSA: aaci: report FIFO size in frames

["Russell King (Oracle)" <linux@armlinux.org.uk>]

On Mon, Apr 01, 2024 at 01:45:27PM +0200, Oswald Buddenhagen wrote:
> On Mon, Apr 01, 2024 at 12:04:51PM +0100, Russell King (Oracle) wrote:
> > I think where the confusion comes from is that fifo_depth is the
> > depth of the hardware FIFO in units of 16-bit quantities, [...]
> > 
> ... irrespective of mono/stereo?
> well, with that explanation it makes sense.
> i recommend that you adjust the comment to make it more helpful/less
> misleading. maybe something like "We configure ALSA to expect the FIFO
> size in bytes. This works best for us, because [...]".

Oh FFS. So you generated a patch based on the contents of a mere
comment? That is NOT how kernel development should be done. Do not do
this.

Comments are not always correct. I guess you don't even have the
hardware, which makes your approach to "kernel development" even more
absurd.

NAK to this patch. NAK to *all* your patches whether I've seen them or
not if this is how you behave.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!