From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH] ALSA: aaci: report FIFO size in frames
Date: Mon, 1 Apr 2024 12:53:18 +0200 [thread overview]
Message-ID: <ZgqSHq6obzwRDfXs@ugly> (raw)
In-Reply-To: <ZgqOZ0B8h3l48aoh@shell.armlinux.org.uk>
On Mon, Apr 01, 2024 at 11:37:27AM +0100, Russell King (Oracle) wrote:
>runtime->hw.fifo_size is only measured in _frames_ if
>SNDRV_PCM_INFO_FIFO_IN_FRAMES is set.
>
yes, which is exactly why the other hunk in the patch sets it.
>So now I have to ask what caused you to generate this patch. I don't
>think you've actually run this driver, so presumably it's by []
>code inspection...
>
yes, it was a random find while trying to make sense of this parameter.
next prev parent reply other threads:[~2024-04-01 10:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 10:13 [PATCH] ALSA: aaci: report FIFO size in frames Oswald Buddenhagen
2024-04-01 10:31 ` Russell King (Oracle)
2024-04-01 10:37 ` Russell King (Oracle)
2024-04-01 10:53 ` Oswald Buddenhagen [this message]
2024-04-01 11:04 ` Russell King (Oracle)
2024-04-01 11:45 ` Oswald Buddenhagen
2024-04-01 13:34 ` Russell King (Oracle)
2024-04-01 14:17 ` Oswald Buddenhagen
2024-04-01 20:59 ` Russell King (Oracle)
2024-04-01 23:01 ` Oswald Buddenhagen
2024-04-01 23:25 ` Russell King (Oracle)
2024-04-02 10:46 ` Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgqSHq6obzwRDfXs@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux@armlinux.org.uk \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox