Set pcbeep to default value

Set pcbeep to default value

[Kailang]

[-- Attachment #1: Type: text/plain, Size: 90 bytes --]

Hi Takashi,

Attach patch will set pcbeep to default value for ALC274.

BR,
Kailang

[-- Attachment #2: 0000-dell-alc274-beep-default.patch --]
[-- Type: application/octet-stream, Size: 745 bytes --]

From 590987836f5f8e565e7fed37256185f5504d6da6 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Thu, 21 Nov 2024 16:16:26 +0800
Subject: [PATCH] Set PCBeep to default value for ALC274

Enable PC beep path cause pop noise via speaker during boot time.
Set to default value will solve the issue.

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 56a3622ca2c1..67036fe6c6cc 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -473,6 +473,8 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
 		break;
 	case 0x10ec0234:
 	case 0x10ec0274:
+		alc_write_coef_idx(codec, 0x6e, 0x0c25);
+		fallthrough;
 	case 0x10ec0294:
 	case 0x10ec0700:
 	case 0x10ec0701:

Re: Set pcbeep to default value

[Takashi Iwai]

On Fri, 22 Nov 2024 08:29:56 +0100,
Kailang wrote:
> 
> Hi Takashi,
> 
> Attach patch will set pcbeep to default value for ALC274.

Could you resubmit with your Signed-off-by tag?

Also, a bit more comment about what this COEF setup is meant would be
helpful.


thanks,

Takashi

RE: Set pcbeep to default value

[Kailang]

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

OK.

> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Monday, November 25, 2024 10:45 PM
> To: Kailang <kailang@realtek.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Subject: Re: Set pcbeep to default value
> 
> 
> External mail.
> 
> 
> 
> On Mon, 25 Nov 2024 03:00:26 +0100,
> Kailang wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Takashi Iwai <tiwai@suse.de>
> > > Sent: Friday, November 22, 2024 5:34 PM
> > > To: Kailang <kailang@realtek.com>
> > > Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> > > Subject: Re: Set pcbeep to default value
> > >
> > >
> > > External mail.
> > >
> > >
> > >
> > > On Fri, 22 Nov 2024 08:29:56 +0100,
> > > Kailang wrote:
> > > >
> > > > Hi Takashi,
> > > >
> > > > Attach patch will set pcbeep to default value for ALC274.
> > >
> > > Could you resubmit with your Signed-off-by tag?
> >
> > Sorry! Attach again.
> 
> You seem to have dropped Cc to alsa-devel ML.
> Also, nowadays we use linux-sound@vger.kernel.org for the main ML for kernel
> patches.  Care to resubmit to there?
> 
> 
> thanks,
> 
> Takashi

[-- Attachment #2: 0000-dell-alc274-beep-default.patch --]
[-- Type: application/octet-stream, Size: 812 bytes --]

From 590987836f5f8e565e7fed37256185f5504d6da6 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Thu, 21 Nov 2024 16:16:26 +0800
Subject: [PATCH] Set PCBeep to default value for ALC274

BIOS Enable PC beep path cause pop noise via speaker during boot time.
Set to default value from driver will solve the issue.

Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 56a3622ca2c1..67036fe6c6cc 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -473,6 +473,8 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
 		break;
 	case 0x10ec0234:
 	case 0x10ec0274:
+		alc_write_coef_idx(codec, 0x6e, 0x0c25);
+		fallthrough;
 	case 0x10ec0294:
 	case 0x10ec0700:
 	case 0x10ec0701:

RE: Set pcbeep to default value

[Kailang]

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

Sorry! Attach again.

Add ALSA: hda/realtek: to Title.

> -----Original Message-----
> From: Kailang
> Sent: Tuesday, November 26, 2024 10:36 AM
> To: 'Takashi Iwai' <tiwai@suse.de>
> Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>;
> 'linux-sound@vger.kernel.org' <linux-sound@vger.kernel.org>
> Subject: RE: Set pcbeep to default value
> 
> OK.
> 
> > -----Original Message-----
> > From: Takashi Iwai <tiwai@suse.de>
> > Sent: Monday, November 25, 2024 10:45 PM
> > To: Kailang <kailang@realtek.com>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Subject: Re: Set pcbeep to default value
> >
> >
> > External mail.
> >
> >
> >
> > On Mon, 25 Nov 2024 03:00:26 +0100,
> > Kailang wrote:
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Takashi Iwai <tiwai@suse.de>
> > > > Sent: Friday, November 22, 2024 5:34 PM
> > > > To: Kailang <kailang@realtek.com>
> > > > Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> > > > Subject: Re: Set pcbeep to default value
> > > >
> > > >
> > > > External mail.
> > > >
> > > >
> > > >
> > > > On Fri, 22 Nov 2024 08:29:56 +0100, Kailang wrote:
> > > > >
> > > > > Hi Takashi,
> > > > >
> > > > > Attach patch will set pcbeep to default value for ALC274.
> > > >
> > > > Could you resubmit with your Signed-off-by tag?
> > >
> > > Sorry! Attach again.
> >
> > You seem to have dropped Cc to alsa-devel ML.
> > Also, nowadays we use linux-sound@vger.kernel.org for the main ML for
> > kernel patches.  Care to resubmit to there?
> >
> >
> > thanks,
> >
> > Takashi

[-- Attachment #2: 0000-dell-alc274-beep-default.patch --]
[-- Type: application/octet-stream, Size: 831 bytes --]

From 590987836f5f8e565e7fed37256185f5504d6da6 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Thu, 21 Nov 2024 16:16:26 +0800
Subject: [PATCH] ALSA: hda/realtek: Set PCBeep to default value for ALC274

BIOS Enable PC beep path cause pop noise via speaker during boot time.
Set to default value from driver will solve the issue.

Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 56a3622ca2c1..67036fe6c6cc 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -473,6 +473,8 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
 		break;
 	case 0x10ec0234:
 	case 0x10ec0274:
+		alc_write_coef_idx(codec, 0x6e, 0x0c25);
+		fallthrough;
 	case 0x10ec0294:
 	case 0x10ec0700:
 	case 0x10ec0701:

Re: Set pcbeep to default value

[Takashi Iwai]

On Tue, 26 Nov 2024 09:05:37 +0100,
Kailang wrote:
> 
> Sorry! Attach again.
> 
> Add ALSA: hda/realtek: to Title.

Applied now.  Thanks.


Takashi