* Re: [alsa-devel] Realtek ALC S1200A
[not found] ` <s5h1rshj5d8.wl-tiwai@suse.de>
@ 2020-01-03 8:46 ` Kailang
2020-01-04 8:23 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Kailang @ 2020-01-03 8:46 UTC (permalink / raw)
To: Takashi Iwai; +Cc: (alsa-devel@alsa-project.org), Lee Harris
[-- Attachment #1: Type: text/plain, Size: 2295 bytes --]
CC alsa-devel.
> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Friday, January 3, 2020 4:45 PM
> To: Kailang <kailang@realtek.com>
> Cc: Lee Harris <lee.r.harris@gmail.com>
> Subject: Re: Realtek ALC S1200A
>
> On Fri, 03 Jan 2020 09:29:59 +0100,
> Kailang wrote:
> >
> > Hi Takashi,
> >
> > Attach was supported patch.
>
> Care to submit to alsa-devel ML? Thanks!
>
>
> Takashi
>
> >
> > BR,
> > Kailang
> >
> > > -----Original Message-----
> > > From: Takashi Iwai <tiwai@suse.de>
> > > Sent: Thursday, January 2, 2020 7:49 PM
> > > To: Lee Harris <lee.r.harris@gmail.com>
> > > Cc: Kailang <kailang@realtek.com>
> > > Subject: Re: Realtek ALC S1200A
> > >
> > > On Thu, 02 Jan 2020 12:41:08 +0100,
> > > Lee Harris wrote:
> > > >
> > >
> > > > Hi Takashi
> > > >
> > > > I saw you had made the changes to sound/pci/hda/patch_realtek.c to
> > > > enable support for the Realtek ALC S1200.
> > > > I hope you don't mind me emailing you?
> > > > My motherboard is an Asus TUF-GAMING-X570-PLUS. The vendors
> > > > product page states it has an Realtek ALC S1200A.
> > > >
> > > > cat /proc/asound/card0/codec#0 shows the following vendor ID
> > > >
> > > > Vendor Id: 0x10ec0b00
> > > > Subsystem Id: 0x10438797
> > > > Revision Id: 0x100001
> > > >
> > > > As standard the sound works but the snd_hda_codec_realtek module
> > > > is not loaded, and the codec is reported as 'Realtek Generic'. I
> > > > can add
> > > > 0x10ec0b00 into patch_realtek.c (just replaced 0x10ec1168 wherever
> > > > it
> > > > occurred!) and the snd_hda_codec_realtek module is loaded, sound
> > > > still
> > > works. Possibly better ?
> > > > No idea If I've done it close to right ? I'm not a programmer,
> > > > just experimenting.
> > > >
> > > > If you need anymore info just let me know.
> > > > Happy new year :)
> > > >
> > > > Regards
> > > > Lee Harris
> > >
> > > Thanks for the report.
> > >
> > > I'd like to hear from Realtek people at first (now Cc'ed).
> > > Kailang, could you check for this new codec?
> > >
> > >
> > > Takashi
> > >
> > > ------Please consider the environment before printing this e-mail.
> > [2 0000-alcs1200a-supported.patch <application/octet-stream (base64)>]
> >
[-- Attachment #2: 0000-alcs1200a-supported.patch --]
[-- Type: application/octet-stream, Size: 1367 bytes --]
From b7698283ce557d27b90fed1cdce67571b705ab72 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Fri, 3 Jan 2020 16:24:06 +0800
Subject: [PATCH] ALSA: hda/realtek - Add new codec supported for ALCS1200A
Add ALCS1200A supported.
It was similar as ALC900.
Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index dbfafee97931..d6dbf6652fe0 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -430,6 +430,7 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
break;
case 0x10ec0899:
case 0x10ec0900:
+ case 0x10ec0b00:
case 0x10ec1168:
case 0x10ec1220:
alc_update_coef_idx(codec, 0x7, 1<<1, 0);
@@ -2525,6 +2526,7 @@ static int patch_alc882(struct hda_codec *codec)
case 0x10ec0882:
case 0x10ec0885:
case 0x10ec0900:
+ case 0x10ec0b00:
case 0x10ec1220:
break;
default:
@@ -9237,6 +9239,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
HDA_CODEC_ENTRY(0x10ec0892, "ALC892", patch_alc662),
HDA_CODEC_ENTRY(0x10ec0899, "ALC898", patch_alc882),
HDA_CODEC_ENTRY(0x10ec0900, "ALC1150", patch_alc882),
+ HDA_CODEC_ENTRY(0x10ec0b00, "ALCS1200A", patch_alc882),
HDA_CODEC_ENTRY(0x10ec1168, "ALC1220", patch_alc882),
HDA_CODEC_ENTRY(0x10ec1220, "ALC1220", patch_alc882),
{} /* terminator */
[-- Attachment #3: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread