[alsa-devel] [PATCH] ASoC: codecs: make PCM5102A codec selectable

[alsa-devel] [PATCH] ASoC: codecs: make PCM5102A codec selectable

[David Douard]

The PCM5102A codec entry in the Kconfig file lacks a title/description
to make it selectable in menuconfig (since it has no dependent i2s/spi 
sub-modules like e.g. the pcm512x one).
---
 sound/soc/codecs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 7e90f5d83097..676fa62e9b7f 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -934,7 +934,7 @@ config SND_SOC_PCM3168A_SPI
 	select REGMAP_SPI
 
 config SND_SOC_PCM5102A
-	tristate
+	tristate "Texas Instruments PCM5102A CODEC"
 
 config SND_SOC_PCM512x
 	tristate
-- 
2.20.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [PATCH] ASoC: codecs: make PCM5102A codec selectable

[Pierre-Louis Bossart]

[Adding Mark Brown - CC: maintainers if you want your patch to be applied]

On 2/13/20 6:25 PM, David Douard wrote:
> The PCM5102A codec entry in the Kconfig file lacks a title/description
> to make it selectable in menuconfig (since it has no dependent i2s/spi
> sub-modules like e.g. the pcm512x one).

For my education, who uses this codec? it's not selected by any machine 
driver?

> ---
>   sound/soc/codecs/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 7e90f5d83097..676fa62e9b7f 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -934,7 +934,7 @@ config SND_SOC_PCM3168A_SPI
>   	select REGMAP_SPI
>   
>   config SND_SOC_PCM5102A
> -	tristate
> +	tristate "Texas Instruments PCM5102A CODEC"
>   
>   config SND_SOC_PCM512x
>   	tristate
> 

Re: [alsa-devel] [PATCH] ASoC: codecs: make PCM5102A codec selectable

[David Douard]

Le 18/02/2020 à 17:04, Pierre-Louis Bossart a écrit :
> [Adding Mark Brown - CC: maintainers if you want your patch to be applied]
> 
> On 2/13/20 6:25 PM, David Douard wrote:
>> The PCM5102A codec entry in the Kconfig file lacks a title/description
>> to make it selectable in menuconfig (since it has no dependent i2s/spi
>> sub-modules like e.g. the pcm512x one).
> 
> For my education, who uses this codec? it's not selected by any machine
> driver?

This codec is needed to drive PCM5102A based i2s DAC. It can be found in
several low cost I2S DAC break boards (I have a Polyvection one for
example) and is generally used on SBC like the RPi, Odroid or Orange Pi.

On such devices, the driver will be selected via a proper declaration of
the device in the device tree (e.g. in a custom dts file). See for
example this issue I submitted to the Armbian project (together with a
PR that patches this very same issue I described in this thread):

  https://github.com/armbian/build/issues/1798

David


>> ---
>>   sound/soc/codecs/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
>> index 7e90f5d83097..676fa62e9b7f 100644
>> --- a/sound/soc/codecs/Kconfig
>> +++ b/sound/soc/codecs/Kconfig
>> @@ -934,7 +934,7 @@ config SND_SOC_PCM3168A_SPI
>>       select REGMAP_SPI
>>     config SND_SOC_PCM5102A
>> -    tristate
>> +    tristate "Texas Instruments PCM5102A CODEC"
>>     config SND_SOC_PCM512x
>>       tristate
>>

Re: [alsa-devel] [PATCH] ASoC: codecs: make PCM5102A codec selectable

[Pierre-Louis Bossart]

>>> The PCM5102A codec entry in the Kconfig file lacks a title/description
>>> to make it selectable in menuconfig (since it has no dependent i2s/spi
>>> sub-modules like e.g. the pcm512x one).
>>
>> For my education, who uses this codec? it's not selected by any machine
>> driver?
> 
> This codec is needed to drive PCM5102A based i2s DAC. It can be found in
> several low cost I2S DAC break boards (I have a Polyvection one for
> example) and is generally used on SBC like the RPi, Odroid or Orange Pi.
> 
> On such devices, the driver will be selected via a proper declaration of
> the device in the device tree (e.g. in a custom dts file). See for
> example this issue I submitted to the Armbian project (together with a
> PR that patches this very same issue I described in this thread):
> 
>    https://github.com/armbian/build/issues/1798

Right, but what I was referring to is what is also suggested in that 
link, codecs are typically selected from a machine driver Kconfig, i.e.

  config SND_SUN4I_I2S
  	tristate "Allwinner A10 I2S Support"
+	depends on OF
  	select SND_SOC_GENERIC_DMAENGINE_PCM
  	select REGMAP_MMIO
+	select SND_SOC_PCM5102A

Your patch provides a means for a user to force the codec driver to be 
compiled in, but it doesn't help select the minimal config needed on a 
given platform. Anyways no real objections so

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>