alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org,
	broonie@kernel.org, rakesh.a.ughreja@intel.com, vkoul@kernel.org
Subject: Re: [PATCH v3 00/13] Enable HDA Codec support on Intel Platforms
Date: Thu, 28 Jun 2018 00:02:06 -0500	[thread overview]
Message-ID: <b1146efd-5bb8-c8ff-fcfe-555f2eee0f65@linux.intel.com> (raw)
In-Reply-To: <c69dbe7e-5b74-334d-abce-cd81da205fe2@linux.intel.com>


>> Now I've put a few patches from the series into topic/hda-core-intel
>> branch of sound git tree: namely,
>>
>>     ALSA: hdac: ext: add wait for codec to respond after link reset
>>     ALSA: hdac: Remove usage of struct hdac_ext_device and use 
>> hdac_device instead
>>     ALSA: hdac: Remove usage of struct hdac_ext_bus and use hdac_bus 
>> instead
>>     ALSA: hdac: Remove usage of struct hdac_ext_driver, use 
>> hdac_driver instead
>>     ALSA: hda: split snd_hda_codec_new function
>>     ALSA: hdac: remove memory allocation from 
>> snd_hdac_ext_bus_device_init
>>     ALSA: hdac: add extended ops in the hdac_bus
>>
>> corresponds to the patch 12 as a fix at first, followed by patches 1,
>> 2, 3 as hdac_ext_* cleanup, and patches 8, 9, 10 for preparation of
>> the further move.  All these should be only cleanups / refactoring
>> (and one fix), hence no visible functional changes.
>>
>> The branch isn't merged to for-next yet.  And it's cleanly based on
>> v4.18-rc1 so that Mark can pull into his tree.  As far as I've
>> checked, the merge can be done smoothly to the current asoc tree,
>> too.
>>
>> So, guys, please check / review whether these are all OK for now.
>>
>> The rest are rather ASoC-intensive part and needs more careful
>> reviews.
>
> Great, thank you, I was about to resend a smaller series but you beat 
> me to it. Will double-check the branch.
Takashi, the 0-day reports that bisect is broken are correct, the first 
patch should be moved after the 3 'Remove usage' patches, i.e. the order 
should be

-   ALSA: hdac: ext: add wait for codec to respond after link reset
     ALSA: hdac: Remove usage of struct hdac_ext_device and use 
hdac_device instead
     ALSA: hdac: Remove usage of struct hdac_ext_bus and use hdac_bus 
instead
     ALSA: hdac: Remove usage of struct hdac_ext_driver, use hdac_driver 
instead
+   ALSA: hdac: ext: add wait for codec to respond after link reset
     ALSA: hda: split snd_hda_codec_new function
     ALSA: hdac: remove memory allocation from snd_hdac_ext_bus_device_init
     ALSA: hdac: add extended ops in the hdac_bus

I haven't done any audio tests with the legacy driver yet but at least 
this change fixes compilation issues.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2018-06-28  5:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-02  3:53 [PATCH v3 00/13] Enable HDA Codec support on Intel Platforms Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 01/13] ALSA: hdac: Remove usage of struct hdac_ext_device and use hdac_device instead Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 02/13] ALSA: hdac: Remove usage of struct hdac_ext_bus and use hdac_bus instead Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 03/13] ALSA: hdac: Remove usage of struct hdac_ext_driver, use hdac_driver instead Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 04/13] ASoC: Intel: Boards: Machine driver for SKL+ w/ HDAudio codecs Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 05/13] ASoC: Intel: Skylake: Add entry in sst_acpi_mach for HDA codecs Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 06/13] ASoC: Intel: Skylake: add HDA BE DAIs Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 07/13] ASoC: Intel: Skylake: use hda_bus instead of hdac_bus Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 08/13] ALSA: hda: split snd_hda_codec_new function Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 09/13] ALSA: hdac: remove memory allocation from snd_hdac_ext_bus_device_init Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 10/13] ALSA: hdac: add extended ops in the hdac_bus Pierre-Louis Bossart
2018-06-02  3:53 ` [PATCH v3 11/13] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers Pierre-Louis Bossart
2018-06-02  3:54 ` [PATCH v3 12/13] ALSA: hdac: ext: add wait for codec to respond after link reset Pierre-Louis Bossart
2018-06-02  3:54 ` [PATCH v3 13/13] ASoC: Intel: Skylake: fix widget handling Pierre-Louis Bossart
2018-06-02  9:00 ` [PATCH v3 00/13] Enable HDA Codec support on Intel Platforms Takashi Iwai
2018-06-04 13:27   ` Pierre-Louis Bossart
2018-06-04 13:33     ` Mark Brown
2018-06-04 13:44     ` Takashi Iwai
2018-06-26 19:04       ` Takashi Iwai
2018-06-27 23:04         ` Pierre-Louis Bossart
2018-06-28  5:02           ` Pierre-Louis Bossart [this message]
2018-06-28  5:34             ` Takashi Iwai
2018-07-04 10:38               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1146efd-5bb8-c8ff-fcfe-555f2eee0f65@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=rakesh.a.ughreja@intel.com \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).