Re: [PATCH v3 00/13] Enable HDA Codec support on Intel Platforms

[Takashi Iwai <tiwai@suse.de>]

On Thu, 28 Jun 2018 07:34:08 +0200,
Takashi Iwai wrote:
> 
> On Thu, 28 Jun 2018 07:02:06 +0200,
> Pierre-Louis Bossart wrote:
> > 
> > 
> > >> Now I've put a few patches from the series into topic/hda-core-intel
> > >> branch of sound git tree: namely,
> > >>
> > >>     ALSA: hdac: ext: add wait for codec to respond after link reset
> > >>     ALSA: hdac: Remove usage of struct hdac_ext_device and use
> > >> hdac_device instead
> > >>     ALSA: hdac: Remove usage of struct hdac_ext_bus and use
> > >> hdac_bus instead
> > >>     ALSA: hdac: Remove usage of struct hdac_ext_driver, use
> > >> hdac_driver instead
> > >>     ALSA: hda: split snd_hda_codec_new function
> > >>     ALSA: hdac: remove memory allocation from
> > >> snd_hdac_ext_bus_device_init
> > >>     ALSA: hdac: add extended ops in the hdac_bus
> > >>
> > >> corresponds to the patch 12 as a fix at first, followed by patches 1,
> > >> 2, 3 as hdac_ext_* cleanup, and patches 8, 9, 10 for preparation of
> > >> the further move.  All these should be only cleanups / refactoring
> > >> (and one fix), hence no visible functional changes.
> > >>
> > >> The branch isn't merged to for-next yet.  And it's cleanly based on
> > >> v4.18-rc1 so that Mark can pull into his tree.  As far as I've
> > >> checked, the merge can be done smoothly to the current asoc tree,
> > >> too.
> > >>
> > >> So, guys, please check / review whether these are all OK for now.
> > >>
> > >> The rest are rather ASoC-intensive part and needs more careful
> > >> reviews.
> > >
> > > Great, thank you, I was about to resend a smaller series but you
> > > beat me to it. Will double-check the branch.
> > Takashi, the 0-day reports that bisect is broken are correct, the
> > first patch should be moved after the 3 'Remove usage' patches,
> > i.e. the order should be
> > 
> > -   ALSA: hdac: ext: add wait for codec to respond after link reset
> >     ALSA: hdac: Remove usage of struct hdac_ext_device and use
> > hdac_device instead
> >     ALSA: hdac: Remove usage of struct hdac_ext_bus and use hdac_bus
> > instead
> >     ALSA: hdac: Remove usage of struct hdac_ext_driver, use
> > hdac_driver instead
> > +   ALSA: hdac: ext: add wait for codec to respond after link reset
> >     ALSA: hda: split snd_hda_codec_new function
> >     ALSA: hdac: remove memory allocation from snd_hdac_ext_bus_device_init
> >     ALSA: hdac: add extended ops in the hdac_bus
> > 
> > I haven't done any audio tests with the legacy driver yet but at least
> > this change fixes compilation issues.
> 
> OK, fixed now.  Thanks!

FYI, I merged the topic/hda-core-intel branch into for-next branch
now, to be included in linux-next for driving this further.

The rest changes are rather ASoC-specific, so I guess they can go
through Mark's tree.  Mark, just pull the branch above if needed.
It should be clean enough to merge.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel