From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Alex Natalsson <harmoniesworlds@gmail.com>
Cc: "ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.de>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
linux-sound@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>
Subject: Re: Sound not working after commit bbf7d3b1c4f40eb02dd1dffb500ba00b0bff0303 on Amlogic A311D device
Date: Mon, 11 Jul 2022 09:33:14 -0500 [thread overview]
Message-ID: <b3e3d969-606f-dede-0319-7b8ed2a975f7@linux.intel.com> (raw)
In-Reply-To: <CADs9LoOJu-NYxPhDL+N+xBtocPNw2y0nRHbSaO-NmGO284GPfA@mail.gmail.com>
On 7/9/22 06:19, Alex Natalsson wrote:
>>> + if (!fe_substream) {
>>> + dev_err(fe->dev, "%s: fe_substream not initialized\n",
>>> __func__);
>>> + return -EINVAL;
>>> + }
>>> + if (!be_substream) {
>>> + dev_err(be->dev, "%s: be_substream not initialized\n",
>>> __func__);
>>> + return -EINVAL;
>>> + }
>>> +
>
> Will be this in upstream or needing bugzilla reporting message?
I created a patch based on this, see
https://github.com/thesofproject/linux/pull/3735
I am not sure however if this is the 'right' fix. There was a comment
from Peter Ujfalusi that a BE substream may be initialized later, but if
that's the case then the atomicity check that was introduced is done in
the wrong location.
Takashi, we could use your guidance here.
Thanks
-Pierre
next prev parent reply other threads:[~2022-07-11 15:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADs9LoPZH_D+eJ9qjTxSLE5jGyhKsjMN7g2NighZ16biVxsyKw@mail.gmail.com>
2022-06-27 15:12 ` Sound not working after commit bbf7d3b1c4f40eb02dd1dffb500ba00b0bff0303 on Amlogic A311D device Pierre-Louis Bossart
2022-06-27 16:52 ` Mark Brown
[not found] ` <CADs9LoN-L0X1Dr1sP2K7xrcWm7dpHW6MhF47c2eBB0moLNnPRQ@mail.gmail.com>
2022-06-28 22:47 ` Pierre-Louis Bossart
[not found] ` <CADs9LoOZjK=cUuNSEELtgxYoA+yHVFKM_Y9YLcY74smqx8XsjQ@mail.gmail.com>
[not found] ` <c554b69c-0c73-158d-85d8-95a0375babeb@linux.intel.com>
2022-07-01 15:47 ` Alex Natalsson
2022-07-01 16:42 ` Pierre-Louis Bossart
2022-07-01 22:17 ` Alex Natalsson
2022-07-09 11:19 ` Alex Natalsson
2022-07-11 14:33 ` Pierre-Louis Bossart [this message]
2022-07-12 8:00 ` Péter Ujfalusi
2022-07-12 9:29 ` Takashi Iwai
2022-07-12 13:05 ` Alex Natalsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3e3d969-606f-dede-0319-7b8ed2a975f7@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=harmoniesworlds@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox