From: "Gorski, Mateusz" <mateusz.gorski@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: cezary.rojewski@intel.com, tiwai@suse.com
Subject: Re: [PATCH 1/4] ASoC: Intel: Skylake: Change the order of machine device and platform registration
Date: Wed, 22 Apr 2020 14:03:53 +0200 [thread overview]
Message-ID: <cb08d66e-6a10-7dd7-c2ee-39e8e84943a4@linux.intel.com> (raw)
In-Reply-To: <bd0e8d65-74ea-8b17-9f92-ed980e265a1c@linux.intel.com>
> Swap the order of machine device and platform device registration.
>> This change ensures that even if the codec enumeration falls late -
>> during
>> the driver module or topology reload - i2s_dev field is always ready to
>> be used.
>
> Are you sure?
>
> The platform device will register the DAIs that are used by the
> machine driver, don't you have a risk of missing dependencies during
> the card registration with this change?
>
> Put differently, why do this now when the existing code has been
> 'working' for a number of years without needing such a change?
>
This change was tested on multiple platforms (including production
laptops) and did not show any issues.
Anyway, in patchset v2 the alt_tplg_name creation mechanism was slightly
changed and this patch was removed.
Thanks for your input,
Mateusz
next prev parent reply other threads:[~2020-04-22 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 20:25 [PATCH 0/4] Add support for different DMIC configurations Mateusz Gorski
2020-04-21 20:25 ` [PATCH 1/4] ASoC: Intel: Skylake: Change the order of machine device and platform registration Mateusz Gorski
2020-04-21 20:49 ` Pierre-Louis Bossart
2020-04-22 12:03 ` Gorski, Mateusz [this message]
2020-04-21 20:25 ` [PATCH 2/4] ASoC: Intel: Skylake: Add alternative topology binary name Mateusz Gorski
2020-04-21 20:25 ` [PATCH 3/4] ASoC: Intel: Multiple I/O PCM format support for pipe Mateusz Gorski
2020-04-21 20:25 ` [PATCH 4/4] ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT Mateusz Gorski
2020-04-21 20:55 ` Pierre-Louis Bossart
2020-04-22 12:04 ` Gorski, Mateusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb08d66e-6a10-7dd7-c2ee-39e8e84943a4@linux.intel.com \
--to=mateusz.gorski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=cezary.rojewski@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox