Re: [PATCH v3 07/17] ASoC: Intel: avs: Add module management requests

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

>>>>>> How come you dont have a loop here? What if the rec'd data size
>>>>>> if
>>>>>> larger than the max size of IP payload?
>>>>> That's not how LARGE_CONFIG_GET message works. There is no
>>>>> looping
>>>>> involved or expected by the firmware and so we don't have it
>>>>> here.
>>>> So, are you saying that when retrieving data from the FW, the size
>>>> of
>>>> the retrieved data can never exceed max IPC payload size?
>>>
>>>
>>>
>>>
>>> Precisely.
>> This is fundmentally flawed isnt it? If set_large_config() sets a
>> config that can exceed max IPC size, get_large_config() has to be able
>> to support it.
> 
> I could ask people on the list to "not look for a second" then there 
> would be no problem explaining all the *recommended flows*.
> 
> Simple, honest answer is: Yes, that's fundamentally flawed.
> Now, as older firmware generations do not expect nor support larger 
> payload sizes, adding such code here is essentially adding dead code so 
> we have decided to add none of it.

Adding a comment and/or an explanation in the commit message wouldn't 
hurt then.