* [PATCH 0/5] treewide: Add missing breaks in switch/case
@ 2011-07-10 9:28 Joe Perches
2011-07-10 9:28 ` [PATCH 5/5] dbri: " Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2011-07-10 9:28 UTC (permalink / raw)
To: linux-wireless, ath5k-devel, linux-usb; +Cc: linux-kernel, netdev, alsa-devel
Found by grep. Uncompiled/untested.
Joe Perches (5):
gpio-tps65910.c: Add missing breaks in switch/case
tps65910-irq: Add missing breaks in switch/case
ath5k: Add missing breaks in switch/case
fusb300_udc: Add missing breaks in switch/case
dbri: Add missing breaks in switch/case
drivers/gpio/gpio-tps65910.c | 2 ++
drivers/mfd/tps65910-irq.c | 2 ++
drivers/net/wireless/ath/ath5k/desc.c | 3 +++
drivers/usb/gadget/fusb300_udc.c | 3 +++
sound/sparc/dbri.c | 5 +++++
5 files changed, 15 insertions(+), 0 deletions(-)
--
1.7.6.131.g99019
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 5/5] dbri: Add missing breaks in switch/case
2011-07-10 9:28 [PATCH 0/5] treewide: Add missing breaks in switch/case Joe Perches
@ 2011-07-10 9:28 ` Joe Perches
2011-07-10 14:36 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2011-07-10 9:28 UTC (permalink / raw)
To: linux-kernel; +Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel
Signed-off-by: Joe Perches <joe@perches.com>
---
sound/sparc/dbri.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c
index 73f9cba..ca978b1 100644
--- a/sound/sparc/dbri.c
+++ b/sound/sparc/dbri.c
@@ -578,14 +578,19 @@ static __u32 reverse_bytes(__u32 b, int len)
switch (len) {
case 32:
b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16);
+ break;
case 16:
b = ((b & 0xff00ff00) >> 8) | ((b & 0x00ff00ff) << 8);
+ break;
case 8:
b = ((b & 0xf0f0f0f0) >> 4) | ((b & 0x0f0f0f0f) << 4);
+ break;
case 4:
b = ((b & 0xcccccccc) >> 2) | ((b & 0x33333333) << 2);
+ break;
case 2:
b = ((b & 0xaaaaaaaa) >> 1) | ((b & 0x55555555) << 1);
+ break;
case 1:
case 0:
break;
--
1.7.6.131.g99019
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5/5] dbri: Add missing breaks in switch/case
2011-07-10 9:28 ` [PATCH 5/5] dbri: " Joe Perches
@ 2011-07-10 14:36 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2011-07-10 14:36 UTC (permalink / raw)
To: linux-kernel; +Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel
On Sun, 2011-07-10 at 02:28 -0700, Joe Perches wrote:
defective patch, please ignore.
> diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c
> index 73f9cba..ca978b1 100644
> --- a/sound/sparc/dbri.c
> +++ b/sound/sparc/dbri.c
> @@ -578,14 +578,19 @@ static __u32 reverse_bytes(__u32 b, int len)
> switch (len) {
> case 32:
> b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16);
> + break;
Maybe add a comment for fall through use instead.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-10 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-10 9:28 [PATCH 0/5] treewide: Add missing breaks in switch/case Joe Perches
2011-07-10 9:28 ` [PATCH 5/5] dbri: " Joe Perches
2011-07-10 14:36 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox