* Re: [PATCH v2] Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")
[not found] <20220706162144.66831-1-Ryan.Wanner@microchip.com>
@ 2022-07-06 16:26 ` Nicolas Ferre
2022-07-06 20:06 ` Cezary Rojewski
1 sibling, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2022-07-06 16:26 UTC (permalink / raw)
To: Ryan.Wanner, Claudiu.Beznea
Cc: devicetree, alsa-devel, broonie, linux-kernel, lgirdwood, robh+dt,
krzysztof.kozlowski+dt, linux-arm-kernel
Hi Ryan,
On 06/07/2022 at 18:21, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Fixed typo in i2s1 node
>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
The "Fixes" tag should go there in this section of the email, and not
replace the subject.
One example of the subject could be:
"[PATCH v2] ARM: dts: at91: sama5d2: fix typo in i2s1 node"
> ---
> Changes since v1:
> 1. Corrected commit
You can place this content about changes...
> ---
Just here, below the "---", so that you don't need to add another "---".
Regards,
Nicolas
> arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 89c71d419f82..659a17fc755c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>,
> clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>;
> clock-names = "pclk", "gclk";
> assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>;
> - assigned-parrents = <&pmc PMC_TYPE_GCK 55>;
> + assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>;
> status = "disabled";
> };
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")
[not found] <20220706162144.66831-1-Ryan.Wanner@microchip.com>
2022-07-06 16:26 ` [PATCH v2] Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers") Nicolas Ferre
@ 2022-07-06 20:06 ` Cezary Rojewski
1 sibling, 0 replies; 2+ messages in thread
From: Cezary Rojewski @ 2022-07-06 20:06 UTC (permalink / raw)
To: Ryan.Wanner, Claudiu.Beznea, nicolas.ferre, alexandre.berna,
robh+dt, broonie, lgirdwood, alsa-devel, krzysztof.kozlowski+dt
Cc: devicetree, linux-kernel, linux-arm-kernel
On 2022-07-06 6:21 PM, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Fixed typo in i2s1 node
Perhaps this email got twisted by my client but what I'm seeing is
fixes-tag instead of a proper commit title.
If that's really the case, please reword your title - Fixes-tag belongs
to the tag area and should be placed before your final signed-off tag.
Also, as commit message is _not_ a title and is made of sentences, it is
expected to have each end with '.'.
Another suggestion - nothing is "Fixed" when patch lands on the mailing
list. It's just a proposal until it actually gets integrated by the
maintainer. As change targets _current_ code, s/Fixed/Fix/ is the
recommended phrasing.
Czarek
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
^ permalink raw reply [flat|nested] 2+ messages in thread