Re: [PATCH] ASoC: codecs: msm8916-wcd-analog: always true condition

[Arvind Yadav <arvind.yadav.cs@gmail.com>]

On Thursday 24 August 2017 03:37 PM, Dan Carpenter wrote:
> Static checkers complain that unsigned int val is always >= 0.  The
> context is that snd_soc_read() returns -1U on error.  This is harmless
> because we're checking that CDC_A_MBHC_RESULT_1_BTN_RESULT_MASK is not
> set, and it will always be set for -1U.  I could have just removed the
> check against -1 but I preserved it because I thought it helped with
> readability.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Arvind Yadav<arvind.yadav.cs@gmail.com 
<mailto:arvind.yadav.cs@gmail.com>>
>
> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index 4aa878d29098..549c269acc7d 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -949,7 +949,7 @@ static irqreturn_t mbhc_btn_release_irq_handler(int irq, void *arg)
>   		u32 val = snd_soc_read(codec, CDC_A_MBHC_RESULT_1);
>   
>   		/* check if its BTN0 thats released */
> -		if ((val >= 0) && !(val & CDC_A_MBHC_RESULT_1_BTN_RESULT_MASK))
> +		if ((val != -1) && !(val & CDC_A_MBHC_RESULT_1_BTN_RESULT_MASK))
>   			priv->mbhc_btn0_pressed = false;
>   
>   	} else {