Question on fe_dai_open

Question on fe_dai_open

[gsantosh]

Hi All,

In the following function

dpcm_fe_dai_open

Why the code is proceeding further if dpcm_path_get returns zero,
if dpcm_path_get returns zero implies there is no vaild path setup.

technically we should return from the function when there is no valid path
setup, still we proceed further de-referencing the pointer at the exit of
this function through dpcm_path_put(&list);

please let me know why we are not returning when dpcm_path_get returns zero.


static int dpcm_fe_dai_open(struct snd_pcm_substream *fe_substream)
{
....
	if (dpcm_path_get(fe, stream, &list) <= 0) {
		dev_dbg(fe->dev, "ASoC: %s no valid %s route\n",
			fe->dai_link->name, stream ? "capture" :
                                          "playback");

            /*we need to return if there is no vaild paths available*/
	}
....
	dpcm_path_put(&list);
}

Regards
Santosh M G

Re: Question on fe_dai_open

[gsantosh]

Hi All,

Please help me on this question.

Regards,
Santosh M G.



> Hi All,
>
> In the following function
>
> dpcm_fe_dai_open
>
> Why the code is proceeding further if dpcm_path_get returns zero,
> if dpcm_path_get returns zero implies there is no vaild path setup.
>
> technically we should return from the function when there is no valid path
> setup, still we proceed further de-referencing the pointer at the exit of
> this function through dpcm_path_put(&list);
>
> please let me know why we are not returning when dpcm_path_get returns
> zero.
>
>
> static int dpcm_fe_dai_open(struct snd_pcm_substream *fe_substream)
> {
> ....
> 	if (dpcm_path_get(fe, stream, &list) <= 0) {
> 		dev_dbg(fe->dev, "ASoC: %s no valid %s route\n",
> 			fe->dai_link->name, stream ? "capture" :
>                                           "playback");
>
>             /*we need to return if there is no vaild paths available*/
> 	}
> ....
> 	dpcm_path_put(&list);
> }
>
> Regards
> Santosh M G
>