Update alc287_fixup_bind_dacs()

Update alc287_fixup_bind_dacs()

[Kailang]

[-- Attachment #1: Type: text/plain, Size: 118 bytes --]

Hi Takashi,

Two speakers platform will common use same function.
So, attach patch was an update.

BR,
Kailang

[-- Attachment #2: 0000-two-speaker-platform.patch --]
[-- Type: application/octet-stream, Size: 1162 bytes --]

From 866966dc46057c2d798ceef6a335f95becd48d4c Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Tue, 12 Sep 2023 15:31:49 +0800
Subject: [PATCH] ALSA: hda/realtek - Fixed two speaker platform

If system has two speakers and one connect to 0x14 pin, use this function will disable it.

Fixes:e43252db7e20 ("ALSA: hda/realtek - ALC287 I2S speaker platform support")
Signed-off-by: Kailang Yang <kailang@realtek.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b7e78bfcffd8..887c1b163865 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7073,8 +7073,10 @@ static void alc287_fixup_bind_dacs(struct hda_codec *codec,
 	snd_hda_override_conn_list(codec, 0x17, ARRAY_SIZE(conn), conn);
 	spec->gen.preferred_dacs = preferred_pairs;
 	spec->gen.auto_mute_via_amp = 1;
-	snd_hda_codec_write_cache(codec, 0x14, 0, AC_VERB_SET_PIN_WIDGET_CONTROL,
-			    0x0); /* Make sure 0x14 was disable */
+	if (spec->gen.autocfg.speaker_pins[0] != 0x14) {
+		snd_hda_codec_write_cache(codec, 0x14, 0, AC_VERB_SET_PIN_WIDGET_CONTROL,
+					0x0); /* Make sure 0x14 was disable */
+	}
 }
 
 

Re: Update alc287_fixup_bind_dacs()

[Takashi Iwai]

On Tue, 12 Sep 2023 10:28:13 +0200,
Kailang wrote:
> 
> Hi Takashi,
> 
> Two speakers platform will common use same function.
> So, attach patch was an update.

Thanks, applied now.


Takashi