From: Eric Miao <eric.y.miao@gmail.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org, Eric Miao <eric.miao@marvell.com>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH] ASoC: pxa-ssp: Don't use SSCR0_SerClkDiv and SSCR0_SCR
Date: Sun, 19 Apr 2009 22:01:33 +0800 [thread overview]
Message-ID: <f17812d70904190701i5cea465anb9a982c33142f0df@mail.gmail.com> (raw)
In-Reply-To: <20090417102257.GA10992@sirena.org.uk>
On Fri, Apr 17, 2009 at 6:22 PM, Mark Brown <broonie@sirena.org.uk> wrote:
> On Fri, Apr 17, 2009 at 11:39:38AM +0200, Philipp Zabel wrote:
>
>> To me, using ssp_dev seems to be cleaner, as all the places where
>> ssp_set_scr is called, we already have an ssp_dev *ssp = priv->dev.ssp
>> set up, which allows us to call ssp_set_scr(ssp, ...) instead of
>> ssp_set_scr(&priv->dev, ...). Same for ssp_get_scr.
>
> Yeah, the combination of ssp_dev and ssp_device is icky in general and
> largely historical as a result of a partially done transition of the
> driver to ssp_device.
>
I'm working on that clean up. A lot of historical and dependency issues
indeed.
And the patch looks OK. The condition of cpu_is_pxa25x() might not
be necessary though, ssp->type == PXA25x_SSP already implies that
and is more specific.
next prev parent reply other threads:[~2009-04-19 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 9:39 [PATCH] ASoC: pxa-ssp: Don't use SSCR0_SerClkDiv and SSCR0_SCR Philipp Zabel
2009-04-17 10:22 ` Mark Brown
2009-04-19 14:01 ` Eric Miao [this message]
2009-04-19 15:03 ` pHilipp Zabel
2009-04-19 15:10 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70904190701i5cea465anb9a982c33142f0df@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=eric.miao@marvell.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox