From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH 00/14] BYT/CHT codec/machine drivers update
Date: Tue, 29 Aug 2017 13:51:33 -0500 [thread overview]
Message-ID: <fbc39e66-9979-e6a0-cef9-841c173ba9d4@linux.intel.com> (raw)
In-Reply-To: <20170829183421.utphkxqjxicedqaj@sirena.org.uk>
On 8/29/17 1:34 PM, Mark Brown wrote:
> On Mon, Aug 28, 2017 at 06:38:25AM -0500, Pierre-Louis Bossart wrote:
>> Mark, please don't merge this for now. There were a couple of minor comments
>> sent privately to me and I need to address them. I will send an update later
>> this week. Thanks.
>
> OK, I did also send you a very major comment about the missing signoffs
> on a lot of the patches...
I must have had an email issue, I didn't see your replies and which
patches you merged, sorry about the noise.
Yes, the missing signed-offs were flagged by Vinod, i didn't know they
were required since they were already posted a while back and I didn't
touch those patches. Point taken, i already fixed this. There was
another issue with a missing error handling which is agreed on with
Thierry Escande. I am also planning to get more testing done for the
maxim codec, I am told that the machine driver worked as is but the code
can't possibly function with a mismatch of both protocol and slot width
so there is something fishy to look into.
prev parent reply other threads:[~2017-08-29 18:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 20:32 [PATCH 00/14] BYT/CHT codec/machine drivers update Pierre-Louis Bossart
2017-08-22 20:32 ` [PATCH 01/14] ASoC: Intel: boards: use devm_clk_get() unconditionally Pierre-Louis Bossart
2017-08-23 14:22 ` Andy Shevchenko
2017-08-22 20:32 ` [PATCH 02/14] ASoC: intel: cht_bsw_max98090: add support for clock framework Pierre-Louis Bossart
2017-08-22 20:32 ` [PATCH 03/14] ASoC: Intel: cht_bsw_max98090: Fix I2S config + unused code Pierre-Louis Bossart
2017-09-19 13:45 ` Applied "ASoC: Intel: cht_bsw_max98090: Fix I2S config + unused code" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 04/14] ASoc: cht_bsw_max98090_ti: Fix jack initialization Pierre-Louis Bossart
2017-08-22 20:32 ` [PATCH 05/14] ASoC: ts3a227e: add acpi table Pierre-Louis Bossart
2017-08-23 11:19 ` Mark Brown
2017-08-22 20:32 ` [PATCH 06/14] ASoC: Intel: atom: add support for Baytrail Chromebooks Pierre-Louis Bossart
2017-09-19 13:45 ` Applied "ASoC: Intel: atom: use cht_bsw_max98090 for Baytrail Chromebooks" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 07/14] ASoC: Intel: bytcr-rt5651: fix capture routes Pierre-Louis Bossart
2017-09-19 13:46 ` Applied "ASoC: Intel: bytcr-rt5651: fix capture routes" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 08/14] ASoC: Intel: bytcr_rt5651: add MCLK support Pierre-Louis Bossart
2017-08-22 20:32 ` [PATCH 09/14] ASoC: Intel: bytcr_rt5651: filter codec name Pierre-Louis Bossart
2017-08-22 20:32 ` [PATCH 10/14] ASoC: codecs: rt5645: add quirks for Asus T100HA Pierre-Louis Bossart
2017-08-23 11:24 ` Applied "ASoC: codecs: rt5645: add quirks for Asus T100HA" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 11/14] ASoC: Intel: bytcr_rt5640: simplify MCLK quirk tests Pierre-Louis Bossart
2017-09-19 13:45 ` Applied "ASoC: Intel: bytcr_rt5640: simplify MCLK quirk tests" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 12/14] ASoC: codecs: rt5670: add jack detection quirk for Dell Venue 5585 Pierre-Louis Bossart
2017-08-23 11:24 ` Applied "ASoC: codecs: rt5670: add jack detection quirk for Dell Venue 5585" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 13/14] ASoC: Intel: cht_bsw_rt5672: use actual HID in suspend/resume Pierre-Louis Bossart
2017-09-25 16:16 ` Applied "ASoC: Intel: cht_bsw_rt5672: use actual HID in suspend/resume" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 14/14] ASoC: Intel: cht_bsw_rt5672: fix card name Pierre-Louis Bossart
2017-09-25 16:16 ` Applied "ASoC: Intel: cht_bsw_rt5672: fix card name" to the asoc tree Mark Brown
2017-08-28 11:38 ` [PATCH 00/14] BYT/CHT codec/machine drivers update Pierre-Louis Bossart
2017-08-29 18:34 ` Mark Brown
2017-08-29 18:51 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbc39e66-9979-e6a0-cef9-841c173ba9d4@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox