From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>, perex@perex.cz
Cc: tiwai@suse.com, pierre-louis.bossart@linux.intel.com,
lgirdwood@gmail.com, peter.ujfalusi@linux.intel.com,
yung-chuan.liao@linux.intel.com, daniel.baluta@nxp.com,
kai.vehmanen@linux.intel.com, broonie@kernel.org,
sound-open-firmware@alsa-project.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] ASoC: SOF: ipc4-topology: Fix an unsigned comparison which can never be negative
Date: Mon, 22 May 2023 13:33:16 -0700 [thread overview]
Message-ID: <ffc0ebdded5e8ec3a00c07347f17f1b78640324f.camel@linux.intel.com> (raw)
In-Reply-To: <20230516081116.71370-1-yang.lee@linux.alibaba.com>
On Tue, 2023-05-16 at 16:11 +0800, Yang Li wrote:
> The return value from the call to sof_ipc4_get_valid_bits() is int.
> However, the return value is being assigned to an unsigned
> int variable 'out_ref_valid_bits', so making it an int.
>
> Eliminate the following warning:
> ./sound/soc/sof/ipc4-topology.c:1537:6-24: WARNING: Unsigned
> expression compared with zero: out_ref_valid_bits < 0
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4985
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
LGTM, thanks!
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
next prev parent reply other threads:[~2023-05-22 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 8:11 [PATCH -next] ASoC: SOF: ipc4-topology: Fix an unsigned comparison which can never be negative Yang Li
2023-05-22 20:33 ` Ranjani Sridharan [this message]
2023-05-23 19:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffc0ebdded5e8ec3a00c07347f17f1b78640324f.camel@linux.intel.com \
--to=ranjani.sridharan@linux.intel.com \
--cc=abaci@linux.alibaba.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox