Re: hdsp fixes

[Takashi Iwai <tiwai@suse.de>]

At Thu, 27 Jan 2005 22:42:28 +0100,
thomas charbonnel wrote:
> 
> Takashi Iwai wrote :
> > Hi,
> > 
> > the following are some things I noticed in the patch:
> > 
> > 
> > > +#define HDSP_PRECISE_POINTER(xname, xindex) \
> > >  { .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
> > >    .name = xname, \
> > >    .index = xindex, \
> > > -  .info = snd_hdsp_info_line_out, \
> > > -  .get = snd_hdsp_get_line_out, \
> > > -  .put = snd_hdsp_put_line_out \
> > > +  .info = snd_hdsp_info_precise_pointer, \
> > > +  .get = snd_hdsp_get_precise_pointer, \
> > > +  .put = snd_hdsp_put_precise_pointer \
> > 
> > Do we need this as a control?
> > Isn't preceise_ptr reliable?
> > 
> 
> It should be reliable now. It was not for the rme9652, and the hdsp code
> forked from there. It was badly broken until recently (Ed Wildgoose's
> patch, IIRC), and I think few people tried it (it defaulted to off). We
> don't really need it as a control, but I thought it would be easier for
> people to test this way. If it proves reliable, I'll eventually remove
> the alternative code.

OK.

> Incidentally, I just sent a new patch without seeing your mail... I'm
> affraid you won't be fond of the new "use midi tasklet" ctl :)

No problem :)


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl