Re: hdsp fixes

[Takashi Iwai <tiwai@suse.de>]

Hi,

the following are some things I noticed in the patch:


> +#define HDSP_PRECISE_POINTER(xname, xindex) \
>  { .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
>    .name = xname, \
>    .index = xindex, \
> -  .info = snd_hdsp_info_line_out, \
> -  .get = snd_hdsp_get_line_out, \
> -  .put = snd_hdsp_put_line_out \
> +  .info = snd_hdsp_info_precise_pointer, \
> +  .get = snd_hdsp_get_precise_pointer, \
> +  .put = snd_hdsp_put_precise_pointer \

Do we need this as a control?
Isn't preceise_ptr reliable?

> +	if (!is_9652 && !is_9632) {
> +		/* we wait 2 seconds to let freshly inserted cardbus cards do their hardware init */
> + 		if ((1000 / HZ) < 2000) {
> +			set_current_state(TASK_UNINTERRUPTIBLE);
> +			schedule_timeout((2000 * HZ + 999) / 1000);
> +		} else {
> +			mdelay(2000);
> +		}

You can use ssleep(2) here.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl