From: Takashi Iwai <tiwai@suse.de>
To: Mohan Kumar <mkumard@nvidia.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, spujar@nvidia.com, tiwai@suse.com,
lgirdwood@gmail.com, robh+dt@kernel.org, jonathanh@nvidia.com,
broonie@kernel.org, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 3/6] ALSA: hda/tegra: Update scratch reg. communication
Date: Wed, 09 Feb 2022 08:09:24 +0100 [thread overview]
Message-ID: <s5h35ksqzx7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220209042326.15764-4-mkumard@nvidia.com>
On Wed, 09 Feb 2022 05:23:23 +0100,
Mohan Kumar wrote:
>
> --- a/include/sound/hda_codec.h
> +++ b/include/sound/hda_codec.h
> @@ -240,6 +240,10 @@ struct hda_codec {
> unsigned int single_adc_amp:1; /* adc in-amp takes no index
> * (e.g. CX20549 codec)
> */
> + unsigned int hdmi_intr_trig_ctrl:1; /* hdmi interrupt trigger
> + * control flag
> + * (e.g. Nvidia codecs)
> + */
This flag is specific to (Nvidia) HDMI codec and referred only from
patch_hdmi.c, right? If so, the flag would be better put locally to
struct hdmi_spec instead of a global hda_codec.
thanks,
Takashi
next prev parent reply other threads:[~2022-02-09 7:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 4:23 [PATCH v1 0/6] Add Tegra234 HDA support Mohan Kumar
2022-02-09 4:23 ` [PATCH v1 1/6] ALSA: hda/tegra: Add Tegra234 hda driver support Mohan Kumar
2022-02-09 4:23 ` [PATCH v1 2/6] ALSA: hda/tegra: Hardcode GCAP ISS value on T234 Mohan Kumar
2022-02-09 4:23 ` [PATCH v1 3/6] ALSA: hda/tegra: Update scratch reg. communication Mohan Kumar
2022-02-09 7:09 ` Takashi Iwai [this message]
2022-02-09 4:23 ` [PATCH v1 4/6] dt-bindings: Add HDA support for Tegra234 Mohan Kumar
2022-02-09 4:23 ` [PATCH v1 5/6] dt-bindings: Document Tegra234 HDA support Mohan Kumar
2022-02-09 4:23 ` [PATCH v1 6/6] arm64: tegra: Add hda dts node for Tegra234 Mohan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h35ksqzx7.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox