From: Takashi Iwai <tiwai@suse.de>
To: Keyon Jie <yang.jie@linux.intel.com>
Cc: jeeja.kp@intel.com, alsa-devel@alsa-project.org,
rakesh.a.ughreja@intel.com, vkoul@kernel.org,
pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH] ALSA: HDA: Fix several mismatch for register mask and value
Date: Mon, 03 Sep 2018 23:50:15 +0200 [thread overview]
Message-ID: <s5h36uqxnc8.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180903024709.56749-1-yang.jie@linux.intel.com>
On Mon, 03 Sep 2018 04:47:09 +0200,
Keyon Jie wrote:
>
> E.g. for snd_hdac_ext_link_clear_stream_id(), we should set (1 << stream)
> as mask, and 0 as value, here correct it and several similar mismatches.
>
> And, here also remove unreadable register_mask usage for those mask value
> updating.
>
> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Thanks, applied now.
Looking at this nice fix, it worries me a bit about the quality of the
code there... We may need to audit the whole code again. Oh well.
Takashi
prev parent reply other threads:[~2018-09-03 21:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 2:47 [PATCH] ALSA: HDA: Fix several mismatch for register mask and value Keyon Jie
2018-09-03 21:50 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h36uqxnc8.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=jeeja.kp@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=vkoul@kernel.org \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox