* [PATCH] ALSA: nm256: constify snd_ac97_res_table
@ 2017-08-24 6:25 Arvind Yadav
2017-08-24 7:13 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-24 6:25 UTC (permalink / raw)
To: perex, tiwai; +Cc: linux-kernel, alsa-devel
snd_ac97_res_table are not supposed to change at runtime. All functions
working with snd_ac97_res_table provided by <sound/ac97_codec.h> work with
const snd_ac97_res_table. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
sound/pci/nm256/nm256.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/nm256/nm256.c b/sound/pci/nm256/nm256.c
index 0ef8054..b97f4ea 100644
--- a/sound/pci/nm256/nm256.c
+++ b/sound/pci/nm256/nm256.c
@@ -1271,7 +1271,7 @@ static int nm256_ac97_idx(unsigned short reg)
}
/* static resolution table */
-static struct snd_ac97_res_table nm256_res_table[] = {
+static const struct snd_ac97_res_table nm256_res_table[] = {
{ AC97_MASTER, 0x1f1f },
{ AC97_HEADPHONE, 0x1f1f },
{ AC97_MASTER_MONO, 0x001f },
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: nm256: constify snd_ac97_res_table
2017-08-24 6:25 [PATCH] ALSA: nm256: constify snd_ac97_res_table Arvind Yadav
@ 2017-08-24 7:13 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-08-24 7:13 UTC (permalink / raw)
To: Arvind Yadav; +Cc: alsa-devel, linux-kernel
On Thu, 24 Aug 2017 08:25:28 +0200,
Arvind Yadav wrote:
>
> snd_ac97_res_table are not supposed to change at runtime. All functions
> working with snd_ac97_res_table provided by <sound/ac97_codec.h> work with
> const snd_ac97_res_table. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-24 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-24 6:25 [PATCH] ALSA: nm256: constify snd_ac97_res_table Arvind Yadav
2017-08-24 7:13 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox