Re: [PATCH 1/3] ALSA: hda - Handle error from snd_hda_power_up*()

[Takashi Iwai <tiwai@suse.de>]

On Wed, 27 Jun 2018 18:09:35 +0200,
Takashi Iwai wrote:
> 
> On Wed, 27 Jun 2018 17:54:31 +0200,
> Chris Wilson wrote:
> > 
> > Quoting Takashi Iwai (2018-06-27 10:10:32)
> > > Although snd_hda_power_up() and snd_hda_power_up_pm() may fail, we
> > > haven't dealt with the error properly in many places.  It's an unusual
> > > situation but still possible.
> > > 
> > > This patch spots these places and adds the proper error paths.
> > > 
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > 
> > Verdict from CI,
> > 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_2430/issues.html
> > 
> > is that this one causes a bunch of pm fallout.
> > 
> > Do you mind doing a quick revert? Or working with our CI to find the bad
> > chunk?
> 
> Hrm, it doesn't look good -- I revert the branch merge now.
> Thanks for the quick heads up.

After a deeper look, I found that it's an error -EACCES from
pm_runtime_get_sync().  Actually it's no real error but indicates that
the runtime PM is disabled.  That's the reason it broke things
easily...

That is, dealing a negative code always as a fatal error is simply
wrong.  We may filter out -EACCES, but I think we need more careful
checks.  So the patch isn't worth, so far.


thanks,

Takashi