From: Takashi Iwai <tiwai@suse.de>
To: Johan Hovold <johan@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org,
Clemens Ladisch <clemens@ladisch.de>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] sound: ua101: fix division by zero at probe
Date: Wed, 27 Oct 2021 08:23:56 +0200 [thread overview]
Message-ID: <s5h7ddzx9xf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20211026095401.26522-1-johan@kernel.org>
On Tue, 26 Oct 2021 11:54:01 +0200,
Johan Hovold wrote:
>
> Add the missing endpoint max-packet sanity check to probe() to avoid
> division by zero in alloc_stream_buffers() in case a malicious device
> has broken descriptors (or when doing descriptor fuzz testing).
>
> Note that USB core will reject URBs submitted for endpoints with zero
> wMaxPacketSize but that drivers doing packet-size calculations still
> need to handle this (cf. commit 2548288b4fb0 ("USB: Fix: Don't skip
> endpoint descriptors with maxpacket=0")).
>
> Fixes: 63978ab3e3e9 ("sound: add Edirol UA-101 support")
> Cc: stable@vger.kernel.org # 2.6.34
> Signed-off-by: Johan Hovold <johan@kernel.org>
Thanks, applied.
Takashi
prev parent reply other threads:[~2021-10-27 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 9:54 [PATCH] sound: ua101: fix division by zero at probe Johan Hovold
2021-10-27 6:23 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7ddzx9xf.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox