From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [RFC PATCH 00/23] ALSA: fix kernel-doc and W=1 warnings
Date: Tue, 07 Jul 2020 12:21:53 +0200 [thread overview]
Message-ID: <s5h7dvfeibi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200702193604.169059-1-pierre-louis.bossart@linux.intel.com>
On Thu, 02 Jul 2020 21:35:41 +0200,
Pierre-Louis Bossart wrote:
>
> This cleanup touches a lot of old - and very old code for hardware
> designed in the late 1990s/early 2000s -, hence the RFC status. I
> mostly did dumb edits just to make warnings go away, suggestions and
> feedback welcome.
>
> Pierre-Louis Bossart (23):
> ALSA: isa/gus: remove -Wmissing-prototypes warnings
> ALSA: isa/gus: remove 'set but not used' warning
> ALSA: pci/asihpi: remove 'set but not used' warnings
> ALSA: pci/asihpi: fix kernel-doc
> ALSA: pci/asihpi: remove 'set but not used' warning
> ALSA: pci/echoaudio: remove 'set but not used' warning
> ALSA: pci/aw2-saa7146: remove 'set but not used' warning
> ALSA: pci/ctxfi/ctatc: fix kernel-doc
> ALSA: pci/ctxfi: fix kernel-doc warnings
> ALSA: usb/line6: remove 'defined but not used' warning
> ASoC: pci/emu10k1: remove "set but not used' warnings
> ALSA: firewire: fix kernel-doc
> ALSA: pci/emu10k1: remove 'set but not used' warning
> ALSA: pci/korg1212: remove 'set but not used' warnings
> ALSA: pci/rme9652/hdspm: remove always true condition
> ALSA: pci/oxygen/xonar_wm87x6: remove always true condition
> ALSA: xen: remove 'set but not used' warning
> ALSA: pci/es1938: remove 'set but not used' warning
> ALSA: pci/fm801: fix kernel-doc
> ALSA: pci/via82xx: remove 'set but not used' warnings
> ALSA: pcmcia/pdaudiocf: fix kernel-doc
> ALSA: vx_core: remove warning for empty loop body
> ALSA: pci/au88x0: remove "defined but not used" warnings
Those look OK although __maybe_unused and __always_unused aren't
always intuitive. At least better than spewing the warnings
unnecessarily.
The line6 patch hasn't been applied yet because it might be clearer to
be replaced with define instead. A similar argument may be applied to
au88x0 code, but this is much uglier and I'd take a more
straightforward fix by your patch.
So, now all but patch#10 are applied to for-next branch.
Thanks!
Takashi
prev parent reply other threads:[~2020-07-07 10:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 19:35 [RFC PATCH 00/23] ALSA: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 01/23] ALSA: isa/gus: remove -Wmissing-prototypes warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 02/23] ALSA: isa/gus: remove 'set but not used' warning Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 03/23] ALSA: pci/asihpi: remove 'set but not used' warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 04/23] ALSA: pci/asihpi: fix kernel-doc Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 05/23] ALSA: pci/asihpi: remove 'set but not used' warning Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 06/23] ALSA: pci/echoaudio: " Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 07/23] ALSA: pci/aw2-saa7146: " Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 08/23] ALSA: pci/ctxfi/ctatc: fix kernel-doc Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 09/23] ALSA: pci/ctxfi: fix kernel-doc warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 10/23] ALSA: usb/line6: remove 'defined but not used' warning Pierre-Louis Bossart
2020-07-07 10:08 ` Takashi Iwai
2020-07-07 15:49 ` Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 11/23] ASoC: pci/emu10k1: remove "set but not used' warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 12/23] ALSA: firewire: fix kernel-doc Pierre-Louis Bossart
2020-07-03 0:56 ` Takashi Sakamoto
2020-07-02 19:35 ` [RFC PATCH 13/23] ALSA: pci/emu10k1: remove 'set but not used' warning Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 14/23] ALSA: pci/korg1212: remove 'set but not used' warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 15/23] ALSA: pci/rme9652/hdspm: remove always true condition Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 16/23] ALSA: pci/oxygen/xonar_wm87x6: " Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 17/23] ALSA: xen: remove 'set but not used' warning Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 18/23] ALSA: pci/es1938: " Pierre-Louis Bossart
2020-07-02 19:36 ` [RFC PATCH 19/23] ALSA: pci/fm801: fix kernel-doc Pierre-Louis Bossart
2020-07-02 19:36 ` [RFC PATCH 20/23] ALSA: pci/via82xx: remove 'set but not used' warnings Pierre-Louis Bossart
2020-07-02 19:36 ` [RFC PATCH 21/23] ALSA: pcmcia/pdaudiocf: fix kernel-doc Pierre-Louis Bossart
2020-07-02 19:36 ` [RFC PATCH 22/23] ALSA: vx_core: remove warning for empty loop body Pierre-Louis Bossart
2020-07-02 19:36 ` [RFC PATCH 23/23] ALSA: pci/au88x0: remove "defined but not used" warnings Pierre-Louis Bossart
2020-07-07 10:21 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7dvfeibi.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox