From: Takashi Iwai <tiwai@suse.de>
To: broonie@kernel.org
Cc: YueHaibing <yuehaibing@huawei.com>,
lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com,
yang.jie@linux.intel.com, perex@perex.cz,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: SOF: Intel: Add missing include file hdac_hda.h
Date: Fri, 09 Aug 2019 14:55:40 +0200 [thread overview]
Message-ID: <s5h7e7mh50z.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5ha7cih53w.wl-tiwai@suse.de>
On Fri, 09 Aug 2019 14:53:55 +0200,
Takashi Iwai wrote:
>
> On Fri, 09 Aug 2019 13:01:00 +0200,
> YueHaibing wrote:
> >
> > Building with SND_SOC_SOF_HDA_AUDIO_CODEC fails:
> >
> > sound/soc/sof/intel/hda-bus.c: In function sof_hda_bus_init:
> > sound/soc/sof/intel/hda-bus.c:16:25: error: implicit declaration of function
> > snd_soc_hdac_hda_get_ops; did you mean snd_soc_jack_add_gpiods? [-Werror=implicit-function-declaration]
> > #define sof_hda_ext_ops snd_soc_hdac_hda_get_ops()
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Suggested-by: Takashi Iwai <tiwai@suse.de>
> > Fixes: d4ff1b3917a5 ('ASoC: SOF: Intel: Initialize hdaudio bus properly")
> ^
> Use " consistently for both opening and closing quotes.
>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Reviewed-by: Takashi Iwai <tiwai@suse.de>
Actually I'm going to take this again on top of
topic/hda-bus-ops-cleanup branch of my tree, so Mark, feel free to
pull onto yours again.
Sorry for the mess!
Takashi
next prev parent reply other threads:[~2019-08-09 12:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 9:55 [PATCH] ASoC: SOF: Intel: Add missing include file hdac_hda.h YueHaibing
2019-08-09 10:04 ` Takashi Iwai
2019-08-09 10:52 ` Yuehaibing
2019-08-09 11:01 ` [PATCH v2] " YueHaibing
2019-08-09 12:31 ` Applied "ASoC: SOF: Intel: Add missing include file hdac_hda.h" to the asoc tree Mark Brown
2019-08-09 12:53 ` [PATCH v2] ASoC: SOF: Intel: Add missing include file hdac_hda.h Takashi Iwai
2019-08-09 12:55 ` Takashi Iwai [this message]
2019-08-09 15:11 ` Mark Brown
2019-08-09 15:19 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7e7mh50z.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox